-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate signature API without context string? #2001
Labels
question
Further information is requested
Comments
This was referenced Nov 19, 2024
fwiw, Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently the signing and verification API within liboqs are as follows:
The API that NIST has introduced in FIPS 204 for ML-DSA includes a context string of length ≥ 0.
PR #1919 adds a new API for signing with a context string:
Once #1919 lands, all signature algorithms would be available under both APIs. For algorithms that do support context strings, if they are called via the old API, it uses a length-0 NULL context string. For algorithms that do not support context strings, if they are called via the new API, it will fail if they use a length >0 context string.
The question in this issue is whether to keep both these APIs indefinitely, or to deprecate the old API. See the discussion of #1919 (e.g., comments A, B, C, D, E). If we were to deprecate the old API, we would at the very least have both APIs in the 0.12.0 release, advertise in the 0.12.0 release notes that the old API will be removed, and then remove the old API in the 0.13.0 release.
The text was updated successfully, but these errors were encountered: