-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make it possible to configure named resource detectors #119
Comments
In The name is the FQCN. |
Dotnet auto instrumentation also has resource detector ids: https://github.com/open-telemetry/opentelemetry-dotnet-instrumentation/blob/main/docs/config.md#resource-detectors According to @matt-hensley, PHP and JS also have the same concept in auto instrumentation projects. This all suggests that resource detector names are a "defacto" feature in the spec, despite them not be explicitly written down. I think we should: 1. Extend the spec to give resource detectors a name / id field. 2. Extend the configuration data model. @codeboten do you think this is required for stability? |
Additional links: Also, being able to specify resource detectors via configuration is something end users have requested. |
Instead of providing a name for a resource detector, should a resource detector be an extension point instead ? This would be aligned with other parts of the configuration provided as components (custom exporter, etc). |
Right now, a typical resource configuration might look like:
Capabilities:
A couple of things are missing:
These types of requirements suggest that a resource detector should be a proper extension point as @marcalff suggests. But I think we probably need a bit more. Here's what an ideal configuration might look like:
Notes:
What to do about
What do folks think? Any other ideas? |
I brought this up in the 2/13/25 java SIG. Was interested in hearing what the java SIG had to say about an opt-in approach to resource detection as I proposed in option 3 above. Talked about a variety of an alternatives and their shortcomings: Object with entries for each detector, each with
|
It would be great to have the capability to configure resource detectors via the configuration file.
For example, the Collector needs to be able to specify that the environment variable resource detector should be used to address open-telemetry/opentelemetry-collector#10909
The text was updated successfully, but these errors were encountered: