Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ot-shim: document the omission of scope manager #2700

Closed
dyladan opened this issue Jan 4, 2022 · 3 comments · Fixed by #5072
Closed

ot-shim: document the omission of scope manager #2700

dyladan opened this issue Jan 4, 2022 · 3 comments · Fixed by #5072
Assignees
Labels
document Documentation-related good first issue Good for newcomers never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers

Comments

@dyladan
Copy link
Member

dyladan commented Jan 4, 2022

There was an issue in opentracing to add a scope manager, but it doesn't look like it was ever implemented opentracing/opentracing-javascript#112

What is our action item here? Should we just document on the shim that there is no scope manager so we have no shim for it?

Originally posted by @dyladan in open-telemetry/opentelemetry-specification#2219 (comment)

@dyladan dyladan added document Documentation-related good first issue Good for newcomers never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jan 4, 2022
@mercybassey
Copy link
Contributor

@dyladan Hi. I am an Outreachy Applicant. Since this is a good first issue can I give it a try?

@pichlermarc
Copy link
Member

@mercybassey looks like @Asheklm6 has closed their PR feel free to give this a try. 🙂

@mercybassey
Copy link
Contributor

@mercybassey looks like @Asheklm6 has closed their PR feel free to give this a try. 🙂

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
document Documentation-related good first issue Good for newcomers never-stale up-for-grabs Good for taking. Extra help will be provided by maintainers
Projects
None yet
3 participants