Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Checker for SSD files. #67

Open
ClemensLinnhoff opened this issue May 25, 2023 · 0 comments
Open

Implement Checker for SSD files. #67

ClemensLinnhoff opened this issue May 25, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@ClemensLinnhoff
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The integration tests are using SSD files to define the system structure, which is simulated by OpenMCx.
First of all, the files need to conform to the SSD schema, otherwise OpenMCx will throw an error.
And secondly it needs to be checked, that the FMI parameters used by OSI (size, base.low, base.hi) are correctly connected. Otherwise this will lead to undefined behavior during the simulation, which can in some edge-cases be hard to detect.
Connecting e.g. a size output to a base.low input can be a careless mistake, when using graphical tools like easy-ssp.

Describe the solution you'd like

  1. Run XML schema validator for every SSD file in the integration tests before starting the co-simulation
  2. Implement a checker, that ensures, that a size output is always connected to a size input (same for base.low and base.hi).
@ClemensLinnhoff ClemensLinnhoff added the enhancement New feature or request label May 25, 2023
@ClemensLinnhoff ClemensLinnhoff self-assigned this May 25, 2023
@ClemensLinnhoff ClemensLinnhoff transferred this issue from another repository Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant