Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2 branch: remove relatedPublication property in LivePaperVersion #26

Open
lzehl opened this issue Jan 29, 2025 · 1 comment
Open

v2 branch: remove relatedPublication property in LivePaperVersion #26

lzehl opened this issue Jan 29, 2025 · 1 comment
Labels
enhancement New feature or request invalid This doesn't seem right

Comments

@lzehl
Copy link
Member

lzehl commented Jan 29, 2025 •
edited
Loading

v2 branch: relatedPublication property in LivePaperVersion is unnecessary because it is inherited from ResearchProductVersion in core.

We leave it for v1 because it is not causing an error, but for maintenance we should remove it from the future branches.
@apdavison or was there a reason that I can't see right now?
@apdavison
Copy link
Member

I think I first introduced the "publicationReference" category only in openMINDS_publications (cd05f82), then we decided to move it to core (openMINDS_core:e8ef70c) and I forgot to remove it from publications.

@Raphael-Gazzotti Raphael-Gazzotti added enhancement New feature or request invalid This doesn't seem right labels Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apdavison @lzehl @Raphael-Gazzotti