Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #641: Change emphasis for Asian languages #673

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Fix #641: Change emphasis for Asian languages #673

merged 1 commit into from
Feb 24, 2025

Conversation

tomschr
Copy link
Collaborator

@tomschr tomschr commented Feb 17, 2025 •
edited
Loading

Add an open and close glyph at the start and end of the emphasis output.

This is the test paragraph:

<para>
   Test: <emphasis>サポート</emphasis>
</para>
<para xml:lang="ko-kr">
   Test ko-kr: 지원되지 <emphasis>않습니다</emphasis>
</para>
<para xml:lang="zh-cn">
  Test zh-cn: 最可靠的方式是<emphasis>修补</emphasis>
</para>

The result is for Japanese:

Screenshot_20250224_160845

@tomschr tomschr marked this pull request as ready for review February 17, 2025 15:41
@tomschr tomschr self-assigned this Feb 24, 2025
@tomschr
Fix #641: Change emphasis for Asian languages
d6b7267 
* Add an open and close glyph at the start and end of the emphasis
output.
* Introduce emphasis-style in l10n to change emphasis output
@tomschr tomschr merged commit 682bdcf into main Feb 24, 2025
2 checks passed
@tomschr tomschr deleted the 641-ja-emphasis branch February 24, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tomschr tomschr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomschr