Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beta:indicativeOffer should have optional @id #399

Open
matdavies opened this issue May 12, 2021 · 0 comments
Open

beta:indicativeOffer should have optional @id #399

matdavies opened this issue May 12, 2021 · 0 comments

Comments

@matdavies
Copy link

matdavies commented May 12, 2021

Given a FacilityUse with the following offers property:

"offers": 
[
  {
    "@type": "beta:IndicativeOffer",
    "identifier": "ven_000229-rbt_000010-rc_000051",
    "name": "Five A Side",
    "price": 67.89,
    "priceCurrency": "GBP"
  }
]

The online validator and validator library flags the following validation error:

- Error: FAILURE: $.facilityUse.offers[0].id: Required property `@id` is missing from `Offer`.

Seems to be applying the rules for Offer instead of those for beta:indicativeOffer. beta:indicativeOffers without @id should be allowed.

@nickevansuk nickevansuk changed the title Online Validator and Validator Library Disagree on beta:indicativeOffer beta:indicativeOffer should have optional @id May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant