You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the single-seller feature is implemented, this test will ensure that all of the opportunity data only belongs to the seller configured in .sellers.primary.
The value is that this will ensure that a Booking System will use the multiple-sellers feature, and thus get that test coverage, if their Booking System actually has multiple sellers.
Why this hasn't been covered by existing tests
It isn't 🦄
Additional context
In theory, it may be possible that a system has opportunity data for multiple sellers but that only one is bookable. This is a very specific scenario, but should technically be considered ok. The multiple-sellers tests ensure that booking fails in the correct ways when multiple seller bookings are performed incorrectly and therefore it's concern is only with bookings and not opportunity.
All this to say that the test should only throw an error if there is BOOKABLE opportunity data belonging to another seller.
It may actually make the most sense to put this in the multiple-sellers feature as a not-implemented test
The solution should use something like FeatureHelper.describeUnmatchedCriteriaFeature(..), which will need to be extended to make it possible to specify that the unmatched criteria constraint should be { criteria: TestOpportunityBookable, sellerNot: SELLER_CONFIG.primary['@id'] }.
This will require changes to Broker Microservice, either extending POST /assert-unmatched-criteria or adding a new similar route for this more complex functionality (a cursory glance suggests the former approach, but this may be incorrect)
The text was updated successfully, but these errors were encountered:
Feature
single-seller
Use Case
When the
single-seller
feature is implemented, this test will ensure that all of the opportunity data only belongs to the seller configured in.sellers.primary
.The value is that this will ensure that a Booking System will use the
multiple-sellers
feature, and thus get that test coverage, if their Booking System actually has multiple sellers.Why this hasn't been covered by existing tests
It isn't 🦄
Additional context
In theory, it may be possible that a system has opportunity data for multiple sellers but that only one is bookable. This is a very specific scenario, but should technically be considered ok. The
multiple-sellers
tests ensure that booking fails in the correct ways when multiple seller bookings are performed incorrectly and therefore it's concern is only with bookings and not opportunity.All this to say that the test should only throw an error if there is BOOKABLE opportunity data belonging to another seller.
It may actually make the most sense to put this in the
multiple-sellers
feature as anot-implemented
testThe solution should use something like
FeatureHelper.describeUnmatchedCriteriaFeature(..)
, which will need to be extended to make it possible to specify that the unmatched criteria constraint should be{ criteria: TestOpportunityBookable, sellerNot: SELLER_CONFIG.primary['@id'] }
.This will require changes to Broker Microservice, either extending
POST /assert-unmatched-criteria
or adding a new similar route for this more complex functionality (a cursory glance suggests the former approach, but this may be incorrect)The text was updated successfully, but these errors were encountered: