Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README for Running with Docker #686

Open
nickevansuk opened this issue Jul 10, 2024 · 0 comments
Open

Update README for Running with Docker #686

nickevansuk opened this issue Jul 10, 2024 · 0 comments

Comments

@nickevansuk
Copy link
Collaborator

nickevansuk commented Jul 10, 2024

The example in README.md is missing a mapping of the openactive-broker-microservice output folder (to ensure that validator output is accessible).

docker run -it \
  -e INPUT_CONFIG=/config/dev.json \
  -e NODE_ENV=dev \
  -p 3000:3000 \
  -v ${PWD}/config:/config \
  -v ${PWD}/packages/openactive-integration-tests/output:/openactive-test-suite/packages/openactive-integration-tests/output \
  ghcr.io/openactive/test-suite:latest \
  -- core

should be

docker run -it \
  -e INPUT_CONFIG=/config/dev.json \
  -e NODE_ENV=dev \
  -p 3000:3000 \
  -v ${PWD}/config:/config \
  -v ${PWD}/packages/openactive-integration-tests/output:/openactive-test-suite/packages/openactive-integration-tests/output \
  -v ${PWD}/packages/openactive-broker-microservice/output:/openactive-test-suite/packages/openactive-broker-microservice/output \
  ghcr.io/openactive/test-suite:latest \
  -- core

And other parts of the document that reference the mapping should also be updated.

This should be tested too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant