Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple IPv6 Static default gateways #64

Open
raviteja-b opened this issue Mar 14, 2023 · 5 comments
Open

Support multiple IPv6 Static default gateways #64

raviteja-b opened this issue Mar 14, 2023 · 5 comments

Comments

@raviteja-b
Copy link
Contributor

As per Redfish schemas and RFCs Multiple static default gateways needs to supported on each interface,

Currently Networkd supports only a single IPv6 default gateway on each interface, but Redfish supports IPv6StaticDefaultGateway collection in the EthernetInterface schema

can we add multiple static default gateways support for each each interface?

@raviteja-b
Copy link
Contributor Author

raviteja-b commented Mar 14, 2023

@wak-google @ratagupt I think we need to support multiple ipv6 static gateway on each interface
what do you think?

@sunharis
Copy link
Contributor

@plmanik
Copy link

plmanik commented Jun 26, 2023

@sunharis
We are not able to see IPv6StaticDefaultGateways in get response and able to use IPv6StaticDefaultGateways in patch request only. IPv6StaticDefaultGateways attribute is not coming in get response of EthernetInterface instance as of now. Hope above changes is returning IPv6StaticDefaultGateways in get response

Thanks,
Mani

@sunharis
Copy link
Contributor

@sunharis We are not able to see IPv6StaticDefaultGateways in get response and able to use IPv6StaticDefaultGateways in patch request only. IPv6StaticDefaultGateways attribute is not coming in get response of EthernetInterface instance as of now. Hope above changes is returning IPv6StaticDefaultGateways in get response

Thanks, Mani

Yes Mani. Please try by picking all these commits together. Existing changes in these should give the IPv6StaticDefaultGateways as mentioned in the bmcweb commit message. I am reworking on the bmcweb commit on the outstanding review comments though.

@plmanik
Copy link

plmanik commented Jun 26, 2023

Thanks @sunharis and we will take changes, check further. Adding one more point from forum(https://redfishforum.com/post/1062/thread) and it applies same for IPv6StaticDefaultGateways

IPv6StaticAddress is the control surface the client can use to request what the static address should be, whereas the IPv6Addresses property shows the actual address of the interface. The reason we have two properties is in case the static address requested by the user cannot be applied at that time, or if there was some fallback condition where a different address was used. Bundling it into a single property could cause confusion where the client PATCHes it to one value, and comes back 5 minutes later to see something else.

Thanks,
Mani

eddiejames pushed a commit to eddiejames/phosphor-networkd that referenced this issue Mar 1, 2024
This issue is caused by a timing problem during the synchronization
between the bios manager and hypervisor network manager, when there
is an ip configuration. The dbus notification from the bios manager
will be received at the hypervisor manager, while the hyp-mgr is still
winding up the static settings.

We have ipv6 settings as well now which may have caused this fraction
of delays.

Tested By:

* Static IP configuration on ethernet interface
* Switching to dhcp config on the same eth interface

Synchronization happens as expected.

Signed-off-by: Asmitha Karunanithi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants