You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During a review to remove some excessive tracing, it was pointed out that the new power supply monitor is requesting and releasing the GPIO line on every "poll".
It is not 100% clear if this is good or bad behavior.
I don't have much of an opinion. It's not terribly different to open/read/close of the sysfs attribute. Do whatever is less of a headache in the code unless we're having performance issues.
During a review to remove some excessive tracing, it was pointed out that the new power supply monitor is requesting and releasing the GPIO line on every "poll".
It is not 100% clear if this is good or bad behavior.
Should the release of the line be removed?
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-power/+/44977/1/phosphor-power-supply/util.cpp#48
The text was updated successfully, but these errors were encountered: