Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add webcam to geopath #2292

Open
kojoty opened this issue Jun 17, 2021 · 4 comments
Open

Can't add webcam to geopath #2292

kojoty opened this issue Jun 17, 2021 · 4 comments

Comments

@kojoty
Copy link
Member

kojoty commented Jun 17, 2021

There is problem with adding cache of type webcam to geopath.
For now geocaches of type:

  • webcam
  • owncache
  • event
    Can't be added to geopath. Additionally this is not handled properly as system doesn't show any error...
@andrixnet
Copy link
Contributor

Whether or not a cache of a certain type should be allowed to be added to a geopath is debateable (at rules level).
IMO technically all cache type should be allowed, and if the rules say otherwise, then it should be a site configuration for this.

Regarding type discussions, my opinions:

  • webcam - yes (don't see why not)
  • owncache - maybe (debateable; should be stationary or otherwise easy to find within the geopath context, at least)
  • event - no, or maybe. (if allowed, perhaps exempt from the geopath completion calculation. but this adds compexity)

@kojoty
Copy link
Member Author

kojoty commented Jun 18, 2021

Hi Andrei,

Previously it was a silent limitation in the code. Now I've moved it to config and it can be modify as a per-node policy - see this:
https://github.com/opencaching/opencaching-pl/pull/2293/files#diff-b59b58bd3b7503bb9ea8e55a6f4940a28888a2eb1dbd11e6f646902c70a11f8cR35

@kojoty
Copy link
Member Author

kojoty commented Jun 18, 2021

PR #2293 containing the fix for this issue

@andrixnet
Copy link
Contributor

I just remembered: IMO "moving cache" type should also be prevented from being part of a Geopath. For obvious reasons :-)

kojoty added a commit that referenced this issue Jun 21, 2021
Fix of the issue #2292: now webcams can be added to geopaths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants