Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old NWP data, check PVnet intraday works #167

Open
peterdudfield opened this issue Jan 20, 2025 · 4 comments
Open

old NWP data, check PVnet intraday works #167

peterdudfield opened this issue Jan 20, 2025 · 4 comments

Comments

@peterdudfield
Copy link
Contributor

We should check that if NWP is old, but still enough steps in the future, that PVnet intraday still runs.

Actually is this behaviour we want? With very old NWP data, we might want it to fail on purpose, so no bad results are made

@dfulu
Copy link
Member

dfulu commented Feb 20, 2025

@peterdudfield what is the intended behaviour here? Currently the app checks if the NWP steps required are available. Do you want to put in a hard failure if the NWP becomes too stale even if it has the required steps?

@peterdudfield
Copy link
Contributor Author

I think this came out of a conversation with the team. Im not sure if im honest. The question might come down to, does PVNet intraday on stale data work better than PVNet DA? Im not sure. Its also might lead to a lot of cases, where if one NWP data is stale, we still allow it, as the model should still use the other NWP data. Or Satellite data wont be stale, so maybe its ok. Yea, im not sure to be honest

@dfulu
Copy link
Member

dfulu commented Feb 20, 2025

I don't see the case for this. For example, say the last NWP timestamp was 6am, and we set a max staleness of say 6 hours. At 1pm (and after) the NWP is "too stale", so we either use the stale NWP data to run the intraday model now, or rely on the last day-ahead forecast which was made a noon.

So if the NWP data becomes too stale, then we just start relying on a stale runtime of our own forecast. That doesn't seem like an advantage to me. The day-ahead model doesn't use satellite, so we'd drop accuracy and we won't have predictions out to 36 hours ahead of present

@peterdudfield
Copy link
Contributor Author

Im not set on this, very much a discussion. I think it came out of a data outage? LIke if Metoffice data is down for 12 hours, is it still ok to run PVnet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants