Refactor

[dfulu]

The whole library needs a good refactor

• Generally tidy up and linting of the code to better code style. e.g. this line that has the close brackets at wrong indentation level but there are lots lots lots more
• We have lots of environmental variables used throughout functions. We should centralise these somewhere and pass them into the functions. E.g. why is this here
• We use the same logic for getting boolean environmental variables a lot. We should make a function for this
• We rely on the sun angle being in the batch for sundown filtering. We should calculate it fresh
• This check should not be done here
• This function should be moved somewhere else
• We never use these options and maybe they should go
• Instead of having this option in the function we should maybe split the function into two parts which each do one thing
• Instead of having these functions maybe we should have a class which handles the data downloads
• We should move this context inside the forecast compiler
• This could just full the name from the forecast compiler instead of the dict
• This is a weird way of wrapping typer
• We should move this to after the data download so we can filter to the models which are available to run immediately
• Better type hinting e.g. here
• This should probably be moved inside the forecast compiler
• This should be removed
• This shouldn't be assigned to dict first
• Weird formatting
• This is really the repo commit hash. I think thats a better name
• Is there any benefit to these pydantic fields having titles? It doesn't actually give any more information
• This model config file should have better line spacing so its easier to read
• Check this. Is there a reason we go 2 days back for GSP capacity but not national
• Unneeded import
• With newer python we can just use tuple
• We repeatedly load data and save it back to disk throughout the data processing steps. This is inefficient
• We have ECMWF renames in multiple places. Eg here and here
• This function name is misleading. We don't really combine them,. just pick
• We can avoid this loop using xarray methods
• This should actually scale by 1023
• Throughout all these functions we should be passing arguments instead of relying on environmental variables
• The way we supply inputs to this function in two ways - once hard coded and once global variable is weird
• This nested try except block is weird