Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indication of model authors #907

Closed
draeger opened this issue Sep 5, 2019 · 4 comments
Closed

Indication of model authors #907

draeger opened this issue Sep 5, 2019 · 4 comments
Assignees
Labels
SBML Related to reading and writing SBML models.

Comments

@draeger
Copy link

draeger commented Sep 5, 2019

The SBML format allows authors to embed their contact information in the form of a VCard, including given name(s) and surname(s), organization, and e-mail address. Also, there are fields for creation date and modification date (see, for instance, SBML Level 3 Version 1 section 6.7, p. 97). This information can be linked to any model component in a history object. In this way, individual parts of models can be associated with specific authors.

Are there any plans to support this as a feature in COBRApy? Being able to attach a VCard just to the model object itself could certainly be helpful to indicate so the authors of a model directly.

@Midnighter
Copy link
Member

Definitely would like to support this.

@ensakz
Copy link

ensakz commented Sep 16, 2019

People usually name GEM by the initials using model.name cobrapy function

@matthiaskoenig
Copy link
Contributor

Hi @draeger,
sorry for the slow reply. Currently the SBML parser is already supporting the feature in a beta version. It is basically using the SBML ModelHistory element and parses it into a python dictionary which can be accessed on the cobra model. This is not really documented but already possible. On SBML export this is not working yet, i.e. the dictionary is not yet serialized in the SBML.

So basically one would just add the typical model author information on the model (name, organization, email) which afterwards would be written in the ModelHistory with the creation date.

I will fix this as part of my next round of SBML bugfixes for cobrapy (busy times right now, but I will likely find time in the next few days).

Best Matthias

@matthiaskoenig matthiaskoenig self-assigned this Sep 16, 2019
@matthiaskoenig matthiaskoenig added the SBML Related to reading and writing SBML models. label Sep 16, 2019
@cdiener
Copy link
Member

cdiener commented Nov 4, 2022

Now tracked in #1237.

@cdiener cdiener closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SBML Related to reading and writing SBML models.
Projects
None yet
Development

No branches or pull requests

5 participants