Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Historical curiosity: Why did we delete half the spec, again? #443

Open
jonjohnsonjr opened this issue Jul 7, 2023 · 5 comments
Open

Historical curiosity: Why did we delete half the spec, again? #443

jonjohnsonjr opened this issue Jul 7, 2023 · 5 comments

Comments

@jonjohnsonjr
Copy link
Contributor

I cannot for the life of me remember why this happened: c90b0f1

There is a ton of stuff missing from distribution-spec, still.

@vbatts
Copy link
Member

vbatts commented Jul 8, 2023

It did improve readability. The spec carried over from Docker had a lot of generated cruft.
But it was a huge endeavor. I wouldn't doubt that things were missed.
What particularly are you finding missing?

@corhere
Copy link

corhere commented Jul 20, 2023

I, for one, am missing the historical context and decision making behind many of the nontrivial spec changes, such as

- Actionable failure conditions, covered in detail in their relevant sections, are reported as part of 4xx responses, in a json response body.
- One or more errors will be returned in the following format:
+ A `4XX` response code from the registry MAY return a body in any format. If the response body is in JSON format, it MUST
+ have the following format:

and how Content-Type: application/octet-stream became a required request header when PATCHing blobs. Before #178 the spec included a table of headers and parameters that SHOULD be included, which did not include the Content-Type header. The Content-Type header was only mentioned in an illustrative example.

Also:

At one point we deprecated catalog, but I can't seem to find reference to it anywhere after #178

@jonjohnsonjr
Copy link
Contributor Author

What particularly are you finding missing?

I can't find any reference to the pagination mechanism for tag listing. I think this got dropped when catalog was [re]moved?

It makes a lot more sense to me now that folks had started inventing new pagination mechanisms for the referrers API: they didn't have the existing mechanism to copy!

@sudo-bmitch
Copy link
Contributor

We also define a chunked upload, but not the streaming upload for blobs.

@vbatts
Copy link
Member

vbatts commented Jul 25, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants