Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests with CgroupPath should choose a different one than '/cgrouptest' #632

Open
alban opened this issue Apr 25, 2018 · 1 comment
Open

Comments

@alban
Copy link
Contributor

alban commented Apr 25, 2018

When looking at PR #631, I noticed it uses the following cgroup:

cgroups/cgroups.go:     AbsCgroupPath = "/cgrouptest"

and the spec says:

Runtimes MAY consider certain cgroupsPath values to be invalid

Runtimes might run under a systemd OS and in that case they should follow systemd guidelines to create the cgroup: CGROUP_DELEGATION.md

There is currently 3 supported ways using systemd:

  • the integrated way: e.g. AbsCgroupPath = "/machine.slice/mycontainer.scope"
  • the island way: I am not sure if that can be expressed with cgroupsPath?
  • the continent way: e.g. AbsCgroupPath = "/ocitest.scope/mycontainer"

If systemd-nspawn implements the OCI runtime spec, it will consider the /cgrouptest cgroup to be invalid. The certification tests should not fail but use a cgroup path that is not considered invalid by the runtime.

/cc @poettering @iaguis

@zhouhao3
Copy link

zhouhao3 commented May 3, 2018

If you have any good ideas, you can open a PR to solve this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants