Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve tool]: implement transfer-leader commnad #2022

Closed
ilixiaocui opened this issue Nov 3, 2022 · 11 comments
Closed

[curve tool]: implement transfer-leader commnad #2022

ilixiaocui opened this issue Nov 3, 2022 · 11 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@ilixiaocui
Copy link
Contributor

ilixiaocui commented Nov 3, 2022

Describe the feature you'd like:

we'd like to support transfer-leader command in curve tool

transfer-leader is one of the commands to make configuration changes to a raft replication group.

  • The implementation of the old tool is here:
    int CurveCli::TransferLeader() {
  • The old command input and out put:
    transfer-leader : transfer the leader of the copyset to the peer
    
    curve_ops_tool transfer-leader --example
    Example
    curve_ops_tool transfer-leader -logicalPoolId=1 -copysetId=10001 -peer=127.0.0.1:8080:0 -conf=127.0.0.1:8080:0,127.0.0.1:8081:0,127.0.0.1:8082:0 -max_retry=3 -timeout_ms=100
    
    output:
    transfer leader ok
    

Teachability, Documentation, Adoption, Migration Strategy:

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

@zhanghuidinah
Copy link
Member

/assign @DHydrogen

@ilixiaocui
Copy link
Contributor Author

Please note that the code submission deadline for this developer activity is December 3rd :)
@DHydrogen

@wuhongsong
Copy link
Contributor

@DHydrogen you are welcome to continue the work if you are free

@ilixiaocui
Copy link
Contributor Author

cc @DHydrogen Since you haven't responded for a long time, this issue is reopened to others who is interested.

@DHydrogen
Copy link

@ilixiaocui I am so sorry that I have been busy preparing for the final exam in the past few weeks, so I had no free time to focus on this task. But as the exams end, I am considering using this long winter vacation to continue to complete it, so I hope you can let me continue this work, or if this work has been taken over by someone else, are there any other free tasks that I can try to work out?

@ilixiaocui
Copy link
Contributor Author

@ilixiaocui I am so sorry that I have been busy preparing for the final exam in the past few weeks, so I had no free time to focus on this task. But as the exams end, I am considering using this long winter vacation to continue to complete it, so I hope you can let me continue this work, or if this work has been taken over by someone else, are there any other free tasks that I can try to work out?

no problem. I saw that there was no reply to the comments before, so I thought you gave up.
Welcome to continue to submit pr!

@DHydrogen
Copy link

Thanks for your encouraging! :)

@zhanghuidinah
Copy link
Member

@Xinlong-Chen
Copy link
Contributor

I am interested in this task, please assign it to me, thanks. @Cyber-SiKu

@ilixiaocui
Copy link
Contributor Author

I am interested in this task, please assign it to me, thanks. @Cyber-SiKu

welcome!

@Cyber-SiKu
Copy link
Contributor

Cyber-SiKu commented Apr 23, 2023

I am interested in this task, please assign it to me, thanks. @Cyber-SiKu

Have you joined our WeChat group?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants