Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] add libfmt to WORKSPACE #2291

Closed
fansehep opened this issue Mar 4, 2023 · 17 comments
Closed

[feature] add libfmt to WORKSPACE #2291

fansehep opened this issue Mar 4, 2023 · 17 comments
Assignees
Labels

Comments

@fansehep
Copy link
Member

fansehep commented Mar 4, 2023

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

We currently use glog as out log output. a log like :

 LOG(INFO) << "XXXX" << "xxx" << "xxxx" << xxx.xxx ...;

libfmt is a fast simple for format lib.
If we use libfmt we can do:

 LOG(INFO) << fmt::format("{} {} {} {}", xxx, xxx, xxx, xxx):

libfmt is support C++11.

From the libfmt benchmark. we can see it is more faster than any style.

Not only fast. libfmt is elegant to use. Seems most cppers hate chain logs. like glog << ugly grammar.

This is the benchmark of libfmt:

2023-03-04_22-03-1677939269

Describe the solution you'd like (描述你期望的解决方法)

Just add fmt to our WORKSPACE, libfmt provide https://github.com/fmtlib/fmt/tree/master/support/bazel for us.
use a stable release version.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@fansehep fansehep added enhancement improve feature feature new feature labels Mar 4, 2023
@Ziy1-Tan
Copy link
Contributor

Ziy1-Tan commented Mar 7, 2023

Great introduction.

@ilixiaocui ilixiaocui added the good first issue Good for newcomers label Mar 8, 2023
@ashutosh887
Copy link

@fansehep Let me work on this Issue

@Cyber-SiKu
Copy link
Contributor

@Tangruilin Are you still working on this issue?

@Cyber-SiKu
Copy link
Contributor

@ashutosh887 Someone is already working on this, you can look at other issues or wait until this person stops doing it.

@caoxianfei1
Copy link
Contributor

@Tangruilin the issue is going on?

@Tangruilin
Copy link
Contributor

@caoxianfei1 @Cyber-SiKu I will finish the issue these days.

Tangruilin added a commit to Tangruilin/curve that referenced this issue Apr 1, 2023
@zhanghuidinah
Copy link
Member

@Tangruilin
Copy link
Contributor

I come to Beijing for work these days and my computer is not here.

This weekend it will be sent to Beijing

@caoxianfei1
Copy link
Contributor

@Tangruilin free to do it.

@ilixiaocui
Copy link
Contributor

@Tangruilin Are you going to follow up on this issue?

@ashutosh887
Copy link

@Cyber-SiKu Is this resolved now?

@Tangruilin
Copy link
Contributor

@Tangruilin Are you going to follow up on this issue?

Maybe this issue should assign to others. I have no time util Aug, I am so sorry

@ashutosh887
Copy link

@ilixiaocui @fansehep
I would like to work on this

@ilixiaocui
Copy link
Contributor

@ilixiaocui @fansehep I would like to work on this

welcome!

@ilixiaocui
Copy link
Contributor

@Tangruilin Are you going to follow up on this issue?

Maybe this issue should assign to others. I have no time util Aug, I am so sorry

Maybe this issue should assign to others. I have no time util Aug, I am so sorry

Never mind!

@caoxianfei1
Copy link
Contributor

caoxianfei1 commented Jun 30, 2023

@ashutosh887 How is going on? any trouble?

@fansehep
Copy link
Member Author

solved with 4ae45e5.

@Cyber-SiKu Cyber-SiKu mentioned this issue Jul 20, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants