-
Notifications
You must be signed in to change notification settings - Fork 524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add libfmt to WORKSPACE #2291
Comments
Great introduction. |
@fansehep Let me work on this Issue |
@Tangruilin Are you still working on this issue? |
@ashutosh887 Someone is already working on this, you can look at other issues or wait until this person stops doing it. |
@Tangruilin the issue is going on? |
@caoxianfei1 @Cyber-SiKu I will finish the issue these days. |
Signed-off-by: tangruilin <[email protected]>
|
I come to Beijing for work these days and my computer is not here. This weekend it will be sent to Beijing |
@Tangruilin free to do it. |
@Tangruilin Are you going to follow up on this issue? |
@Cyber-SiKu Is this resolved now? |
Maybe this issue should assign to others. I have no time util Aug, I am so sorry |
@ilixiaocui @fansehep |
welcome! |
Never mind! |
@ashutosh887 How is going on? any trouble? |
solved with 4ae45e5. |
Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)
We currently use glog as out log output. a log like :
LOG(INFO) << "XXXX" << "xxx" << "xxxx" << xxx.xxx ...;
libfmt is a fast simple for format lib.
If we use libfmt we can do:
libfmt is support C++11.
From the libfmt benchmark. we can see it is more faster than any style.
Not only fast. libfmt is elegant to use. Seems most cppers hate chain logs. like glog
<<
ugly grammar.This is the benchmark of libfmt:
Describe the solution you'd like (描述你期望的解决方法)
Just add fmt to our WORKSPACE, libfmt provide https://github.com/fmtlib/fmt/tree/master/support/bazel for us.
use a stable release version.
Describe alternatives you've considered (描述你想到的折衷方案)
Additional context/screenshots (更多上下文/截图)
The text was updated successfully, but these errors were encountered: