Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[curve/toos-v2]: add client-status #2345

Closed
Cyber-SiKu opened this issue Mar 30, 2023 · 4 comments
Closed

[curve/toos-v2]: add client-status #2345

Cyber-SiKu opened this issue Mar 30, 2023 · 4 comments
Assignees
Labels
enhancement improve feature good first issue Good for newcomers

Comments

@Cyber-SiKu
Copy link
Contributor

Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)

we'd like to support bs status client command in curve tool

  • The implementation of the old tool is here:
    int StatusTool::PrintClientStatus() {
    std::cout << "Client status: " << std::endl;
    ClientVersionMapType versionMap;
    int res = versionTool_->GetClientVersion(&versionMap);
    if (res != 0) {
    std::cout << "GetClientVersion fail" << std::endl;
    return -1;
    }
    for (const auto& item : versionMap) {
    std::cout << item.first << ": ";
    bool first = true;
    for (const auto& item2 : item.second) {
    if (!first) {
    std::cout << ", ";
    }
    std::cout << "version-" << item2.first << ": "
    << item2.second.size();
    first = false;
    }
    std::cout << std::endl;
    if (FLAGS_detail) {
    std::cout << "version map: " << std::endl;
    versionTool_->PrintVersionMap(item.second);
    }
    }
    return 0;
    }
  • The old command input and out put:
curve_ops_tool client-status --detail

-------
output:
Client status: 
nebd-server: ***: ***
version map: 
***: {***:***}

Refer to tool develop guide to get start, and paste the result of the command in pr.

Build compilation environment:https://github.com/opencurve/curve/blob/master/docs/cn/build_and_run.md

Describe the solution you'd like (描述你期望的解决方法)

Add subcommand clinet to curve bs list.

Describe alternatives you've considered (描述你想到的折衷方案)

Additional context/screenshots (更多上下文/截图)

@y-ykcir
Copy link

y-ykcir commented Apr 11, 2023

@Cyber-SiKu I want to try it, can you assign it to me?

@Cyber-SiKu
Copy link
Contributor Author

@Cyber-SiKu I want to try it, can you assign it to me?

done!

@zhanghuidinah
Copy link
Member

@Xinlong-Chen
Copy link
Contributor

@Cyber-SiKu I am interested in this task, please assign it to me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve feature good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants