Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-9411 - Update-Istio #393

Closed
wants to merge 17 commits into from

Conversation

mholder6
Copy link

What this PR does / why we need it:
Updated the istio libraries based on go versioning 1.21

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Checklist:

  • Have you added unit/e2e tests that prove your fix is effective or that this feature works?
  • Has code been commented, particularly in hard-to-understand areas?
  • Have you made corresponding changes to the documentation?

Release note:


Re-running failed tests

  • /rerun-all - rerun all failed workflows.
  • /rerun-workflow <workflow name> - rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.

calwoo and others added 17 commits June 21, 2024 06:18
* propagate trc bool across vllm init

Signed-off-by: Calvin Woo <[email protected]>
Signed-off-by: calvin d. woo <[email protected]>

* use args directly to avoid undefined var

Signed-off-by: Calvin Woo <[email protected]>
Signed-off-by: calvin d. woo <[email protected]>

* Remove trailing space

Signed-off-by: Dan Sun <[email protected]>
Signed-off-by: calvin d. woo <[email protected]>

* move params to newline

Signed-off-by: calvin d. woo <[email protected]>

---------

Signed-off-by: Calvin Woo <[email protected]>
Signed-off-by: calvin d. woo <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
The KServe Python SDK README.md uses relative URLs that work well on GitHub but return a 404 error when visited on PyPI.

This change updates the README.md to use absolute URLs that work well on both GitHub and PyPI.

Signed-off-by: kevinbazira <[email protected]>
check empty model final.

Signed-off-by: HAO <[email protected]>
Co-authored-by: koshino17 <[email protected]>
* Fix No model ready error in multi model serving

- Fixes the regression introduced by kserve#3275

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Mark transformer model ready in init method

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Initial implementation of inference client

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Use Inference client for e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Upgrade pytest-asyncio to 0.23.4

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix mutable object initialization in default parameters

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix graph e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix pmml test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add explain, support dict response, use inference client for internal requests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix inference graph test and grpc headers

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Remove v1 datamodels

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Introduce protocol in client config

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Support inference graph

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

remove logging configs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Update default timeout to 60 seconds

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add retry config for grpc client

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix infer model_name parameter

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add tests for graph endpoint

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

debug

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

fix http client param mismatch

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

skip graph test

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

fix timeout in grpc client

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix url construction

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix explain

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* configure logger for e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Rebase master

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Rebase master

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix grpc retry config

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Increase request timeout

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* configure logger for e2e tests

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Rebase master

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Rebase master

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Fix grpc retry config

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

Increase request timeout

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Rebase

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Use fixtures for rest client

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Fix model name not properly parsed by inference graph

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Handle single string arg with excess whitespace

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Handle duplicate arguments

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
Signed-off-by: Dan Sun <[email protected]>
Co-authored-by: Dan Sun <[email protected]>
empty commit

Signed-off-by: Spolti <[email protected]>
Use add_generation_rompt for chat template

Signed-off-by: Dattu Sharma <[email protected]>
* Deduplicate the names for the additional domain names

Signed-off-by: Vincent Hou <[email protected]>

* Refactoring the functions

Signed-off-by: Vincent Hou <[email protected]>

---------

Signed-off-by: Vincent Hou <[email protected]>
virtual service case insensitive

Signed-off-by: Andrews Arokiam <[email protected]>
* Install packages needed for model load

Signed-off-by: Gavrish Prabhu <[email protected]>

* make all apt get into a single line

Signed-off-by: Gavrish Prabhu <[email protected]>

---------

Signed-off-by: Gavrish Prabhu <[email protected]>
…serve#3789)

* Add readiness probe for mlserver in CI

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Increase memory limit for pmml test to prevent OOMKilled and read timeout error

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
* Fix logprobs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix a scenario where stream completion fails if echo is true and logprobs is nil

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Fix a scenario where completion fails if the prompt is token_ids and echo is set to true

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Respect tokenizer revision

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

* Add workaround for adding None to token_logprobs and top_logprobs

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>

---------

Signed-off-by: Sivanantham Chinnaiyan <[email protected]>
agent watcher unit test is always flaky so increase timeout to make it stable

Signed-off-by: jooho lee <[email protected]>
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from Jooho and terrytangyuan July 29, 2024 14:34
Copy link

openshift-ci bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mholder6
Once this PR has been reviewed and has the lgtm label, please assign dtrifiro for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 29, 2024

@mholder6: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-slow ec46492 link true /test e2e-slow
ci/prow/e2e-fast ec46492 link true /test e2e-fast
ci/prow/e2e-raw ec46492 link true /test e2e-raw
ci/prow/pr-image-mirror-kserve-storage-initializer ec46492 link true /test pr-image-mirror-kserve-storage-initializer
ci/prow/images ec46492 link true /test images
ci/prow/pr-image-mirror-kserve-controller ec46492 link true /test pr-image-mirror-kserve-controller
ci/prow/pr-image-mirror-kserve-agent ec46492 link true /test pr-image-mirror-kserve-agent
ci/prow/pr-image-mirror-kserve-router ec46492 link true /test pr-image-mirror-kserve-router

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mholder6 mholder6 closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.