Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for requests with content-type application/x-www-form-urlencoded and multipart/form-data #77

Open
November22 opened this issue Nov 11, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@November22
Copy link

When i add a header "content-type" as the value is "application/x-www-form-urlencoded", diffy system could not get the request body.

postman:
image

diffy:
image

@puneetkhanduri puneetkhanduri self-assigned this Nov 15, 2022
@puneetkhanduri puneetkhanduri added enhancement New feature or request good first issue Good for newcomers labels Nov 18, 2022
@puneetkhanduri
Copy link
Collaborator

application/x-www-form-urlencoded and multipart/form-data are currently not supported.

I invite you to take a look at how reactor can support your use case here.

and contribute a patch to Diffy here.

@puneetkhanduri puneetkhanduri changed the title Content-Type:application/x-www-form-urlencoded ,diffy system could not get the request body. Add support for requests with content-type application/x-www-form-urlencoded and multipart/form-data Nov 18, 2022
@November22
Copy link
Author

Thank you for your invitation. The branch tag I use is 22.10.13.00, which will cause such problems. This problem does not occur when I use the current master branch.

The equals method of the screenshot will not take effect.

image

I use a translation tool. Please forgive me for any inaccuracies。

@puneetkhanduri
Copy link
Collaborator

Thanks for pointing this out. The fix has been pushed to master.

@abhishek1811
Copy link

@puneetkhanduri I am having the same issue if pass the host header as well.

@abhishek1811
Copy link

@puneetkhanduri - It looks when we send Host header in the request, it is short circuiting the request or may be an exception is happening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants