Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Which problem configuration fields should be edit-able in a library problem? #1317

Closed
Tracked by #1511 ...
jmakowski1123 opened this issue Sep 23, 2024 · 11 comments
Closed
Tracked by #1511 ...

Comments

@jmakowski1123
Copy link

When creating a problem in a library, I may not know which course the problem will be used in. Or the problem may be used in multiple courses, each with different grading parameters. Thus, I'd expect that the only configurable fields attached to a problem in a library are the generalized fields that apply to the problem content itself, and not the overall grading schema. Those fields are:

  • Type
  • Hints
  • Feedback

I would not expect to see the following configurable fields attached to a problem in a Library. Instead, I would expect to configure these fields within the course outline, such that my configurations are specific to the grading schema of that particular course:

  • Scoring - point weight
  • Scoring - number of attempts/unlimited attempts
  • Time between attempts
  • Show answer parameters
  • Show reset option
@jmakowski1123 jmakowski1123 converted this from a draft issue Sep 23, 2024
@bradenmacdonald
Copy link
Contributor

@jmakowski1123 Would you like me to go ahead and disable those fields? And/or display a note that they're not configurable in libraries? Or does this need some more work to figure out the best approach?

@kdmccormick
Copy link
Member

(following this since it affects the backend)

@bradenmacdonald
Copy link
Contributor

This will be post-Sumac.

@kdmccormick
Copy link
Member

@jmakowski1123 @bradenmacdonald For Sumac, what should happen if I make local edits to a block from a library, and then pull updates from a library? Options are:

  1. Local edits always stay.
  2. Local edits always get blown away.
  3. Certain local edits stay, certain local edits get blown away.

@bradenmacdonald
Copy link
Contributor

@kdmccormick I thought we had an allowlist of fields that make sense to override, like "max attempts", "max score' etc., and anything other than those would get blown away.

@kdmccormick
Copy link
Member

@bradenmacdonald Yep, just confirming that we haven't changed on that

@kdmccormick
Copy link
Member

In the UI, do we need a way to revert those "customizable" fields to their defaults?

@bradenmacdonald
Copy link
Contributor

@kdmccormick Up to @jmakowski1123 but I'd say it's not necessary for MVP.

@jmakowski1123
Copy link
Author

Nothing in this ticket will be part of the the MVP. Sorry for the confusion.

@pomegranited
Copy link
Contributor

pomegranited commented Jan 28, 2025

@jmakowski1123 @lizc577 @sdaitzman @marcotuts This is ready for AC testing on the sandbox.

Testing instructions:

  1. Create a problem block in a Content Library.
  2. Edit the problem and fill in the question, answer, etc fields.
    Note that all the problem settings besides "Hints" have been removed from the library block UI, and you can still convert to the Advanced editor.
  3. Publish the updated problem block.
  4. Copy the problem block to the Studio clipboard.
  5. Paste it into a Course Unit.
  6. Edit the pasted problem block in the course, and modify the settings fields e.g Attempts, Show Answer, Score
    Note that you can update all of the problem settings fields in the course block UI.
  7. Save changes to the course problem block.
  8. Edit the original library problem, and re-publish.
  9. Sync updates to the course problem block.
    Note that the problem settings customizations made to the course problem block are preserved.

Notes:

  • When previewing the "updates available" to a course problem block, the updated library (upstream) block is shown with the default settings that were saved to the block, e.g. attempts are unlimited, score is 1 point.
    Despite what is implied by that UI, these settings will not be copied into the course (downstream) block, as this change preserves these settings in the downstream block.

@pomegranited pomegranited moved this from Early ideas to Ready for AC testing in Libraries Overhaul Jan 28, 2025
@edschema
Copy link

This looks good to me. All works as expected following @pomegranited testing instructions.

@github-project-automation github-project-automation bot moved this from Ready for AC testing to Done in Libraries Overhaul Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

5 participants