Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question panel doesn't look good in dark mode #1040

Closed
Tracked by #684
jasmeet0817 opened this issue Jan 28, 2022 · 7 comments
Closed
Tracked by #684

Question panel doesn't look good in dark mode #1040

jasmeet0817 opened this issue Jan 28, 2022 · 7 comments
Assignees
@GowthamGoush
Labels
darkmode Ensuring we look good in the dark good first issue Good for newcomers 🤖 Robotoff 🎨 UI / UX

Comments

@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 28, 2022 •
edited by teolemon
Loading

What

  • Find a product with unanswered question
  • Switch to dark mode

The panel asking users to answer the question looks bad.

Screenshot

image

Part of
@teolemon teolemon added darkmode Ensuring we look good in the dark 🤖 Robotoff labels Jan 29, 2022
@teolemon teolemon mentioned this issue Jan 29, 2022
Closed
14 tasks
@teolemon
Copy link
Member

image

@teolemon teolemon changed the title Question panel doesn't look good in dark more Question panel doesn't look good in dark mode Feb 5, 2022
@GowthamGoush
Copy link
Contributor

Hello, I would like to fix this. But could you please help me with what I should change, the color of the text or the card's color? Also, I will be more than happy to know if there is any other better approach.

@M123-dev
Copy link
Member

@GowthamGoush, there are probably some hardcoded color values which need to be changed. The card background color as well as the text color

@GowthamGoush
Copy link
Contributor

Alright, got it!

@GowthamGoush
Copy link
Contributor

GowthamGoush commented Mar 16, 2022 •
edited
Loading

I made the necessary change, but could you please verify if it is good enough for the dark mode? If not, I would love to hear your suggestions.

@teolemon
Copy link
Member

LGTM 👍

@GowthamGoush GowthamGoush mentioned this issue Mar 17, 2022
Closed
@M123-dev M123-dev linked a pull request Mar 19, 2022 that will close this issue
fix: Question panel dark mode color #1249
Closed
@M123-dev M123-dev mentioned this issue Mar 20, 2022
Closed
@teolemon
Copy link
Member

fixed

Repository owner moved this from In Progress to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Mar 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GowthamGoush GowthamGoush

Labels
darkmode Ensuring we look good in the dark good first issue Good for newcomers 🤖 Robotoff 🎨 UI / UX
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Question panel dark mode color GowthamGoush/smooth-app
4 participants
@teolemon @jasmeet0817 @M123-dev @GowthamGoush