Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scanning experience (tracker) #1255

Closed
6 of 15 tasks
teolemon opened this issue Mar 18, 2022 · 7 comments
Closed
6 of 15 tasks

Scanning experience (tracker) #1255

teolemon opened this issue Mar 18, 2022 · 7 comments
Labels
🎯 P0 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Milestone
Trackers

Comments

@teolemon
Copy link
Member

teolemon commented Mar 18, 2022 •
edited by M123-dev
Loading

What

Smoothie should have an excellent scanning experience on Android and iPhone

Related issues to solve

Part of
@teolemon teolemon mentioned this issue Mar 18, 2022
Open
@teolemon teolemon added the 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… label Mar 18, 2022
@M123-dev
Copy link
Member

The ML-Kit test could be misleading, as it could be that the scanner doesn't work at all

@cli1005
Copy link
Contributor

cli1005 commented Mar 23, 2022

The ML-Kit test could be misleading, as it could be that the scanner doesn't work at all

Good to try 😉 , is it possible to add a merge check workflow detecting building error or warning which will block the release? a wokflow github action launching the command "flutter build" on PR creation

@M123-dev
Copy link
Member

Yes we actually do something like this. Here the workflow for every merged PR: https://github.com/openfoodfacts/smooth-app/blob/develop/.github/workflows/postsubmit.yml

But it's just a android build

@g123k g123k self-assigned this Mar 28, 2022
@g123k g123k mentioned this issue Mar 28, 2022
Open
4 tasks
@g123k
Copy link
Collaborator

g123k commented Mar 28, 2022

Before starting anything on the Flutter side, we will test some improvements on the Android app.
If they are successful, we will then implement here.

To follow our tests on Android: openfoodfacts/openfoodfacts-androidapp#4619

@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@g123k g123k moved this from Todo (ready 2 dev) to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Apr 2, 2022
@g123k g123k mentioned this issue Apr 4, 2022
Closed
@teolemon teolemon changed the title Smoothie should have an excellent scanning experience on Android and iPhone Scanning experience (tracker) May 24, 2022
@teolemon teolemon moved this from In Progress to To reproduce in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 24, 2022
@teolemon teolemon modified the milestones: V1, Trackers May 24, 2022
@teolemon
Copy link
Member Author

I'm clarifying that this is a tracker.

@g123k
Copy link
Collaborator

g123k commented Jun 9, 2022 •
edited by teolemon
Loading

  • Link to Include a Logger #2217 added.
    I think once this one will be implemented, there won't be much to do, isn't it?

@M123-dev
Copy link
Member

I'd say this issue is now obsolete we have lots of issues with more up to date infos about this topic

Repository owner moved this from To reproduce to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎯 P0 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Trackers
Development

No branches or pull requests
4 participants
@g123k @teolemon @M123-dev @cli1005