Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode issues #3214

Closed
teolemon opened this issue Oct 25, 2022 · 12 comments
Closed

Dark mode issues #3214

teolemon opened this issue Oct 25, 2022 · 12 comments
Labels
before next release obvious and / or dangerous bug 🐛 bug Something isn't working darkmode Ensuring we look good in the dark 🎯 P1

Comments

@teolemon
Copy link
Member

teolemon commented Oct 25, 2022

What

  • Dark mode issues

Part of

Screenshot/Mockup/Before-After

Screenshot_20221025-082518.png

@teolemon teolemon added the 🐛 bug Something isn't working label Oct 25, 2022
@teolemon teolemon added the darkmode Ensuring we look good in the dark label Oct 25, 2022
@teolemon
Copy link
Member Author

Screenshot_20221025-085008.png

@Akashsri3bi
Copy link
Contributor

I will see to it @teolemon !

@Akashsri3bi
Copy link
Contributor

These were fixed I guess in back button not visible issue !

@M123-dev
Copy link
Member

Doesn't look like it, I have this problem on the latest commit

@M123-dev M123-dev added 🎯 P1 before next release obvious and / or dangerous bug and removed P4 labels Oct 28, 2022
@M123-dev
Copy link
Member

Added before next release, we shouldn't release so obvious bugs

@Akashsri3bi
Copy link
Contributor

It seems fine on my device , Should I attach a screenshot ?

@Akashsri3bi
Copy link
Contributor

Can you attach a screenshot @M123-dev where this issue persists

@Akashsri3bi
Copy link
Contributor

@M123-dev yes this issue is there I will see to it

@M123-dev
Copy link
Member

M123-dev commented Nov 3, 2022

When do you think you will be able to have a look at it @Akashsri3bi

@M123-dev M123-dev moved this from To discuss and validate to In Progress in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 3, 2022
@M123-dev M123-dev moved this from In Progress to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 3, 2022
@M123-dev
Copy link
Member

M123-dev commented Nov 4, 2022

@Akashsri3bi I just PRed #3264

Because we plan to release very soon

@Akashsri3bi
Copy link
Contributor

I am really sorry @M123-dev , I got busy . It's really nice you did that !

@M123-dev
Copy link
Member

M123-dev commented Nov 7, 2022

No problem 👍🏼

@M123-dev M123-dev closed this as completed Nov 7, 2022
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
before next release obvious and / or dangerous bug 🐛 bug Something isn't working darkmode Ensuring we look good in the dark 🎯 P1
Development

No branches or pull requests

3 participants