Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White on white status bar (regression) #5783

Closed
g123k opened this issue Nov 3, 2024 · 7 comments · Fixed by #5784
Closed

White on white status bar (regression) #5783

g123k opened this issue Nov 3, 2024 · 7 comments · Fixed by #5784

Comments

@g123k
Copy link
Collaborator

g123k commented Nov 3, 2024

Hi everyone!

I think we have another regression with Material 3: the color of the status bar.
Here on Android with the light theme:

Image
Image
Image
Image

@monsieurtanuki
Copy link
Contributor

A solution would be not to try to expand our content or colors to the status bar, and let the system work the way it's supposed to work.

@teolemon
Copy link
Member

teolemon commented Nov 4, 2024

iOS and Android actually have provisions for that, for a more immersive experience, and are actively encouraging apps to adopt it.

@monsieurtanuki
Copy link
Contributor

Fun fact: none of the apps on my new smartphone have that "immersive feature", not even:

  • Google apps (including Drive showing photos)
  • Samsung games from Gaming Hub - either full screen or with a normal status bar

@g123k g123k linked a pull request Nov 4, 2024 that will close this issue
@g123k
Copy link
Collaborator Author

g123k commented Nov 4, 2024

I'm sorry, but I need to prepare you for what's coming 😅
https://github.com/user-attachments/assets/c5073cfb-d4b5-48fd-b6f5-e889574efc1e

@monsieurtanuki
Copy link
Contributor

@g123k Oh I'm not surprised 😉

@teolemon
Copy link
Member

teolemon commented Nov 4, 2024

Google Maps, Gmail… on my phone all have up and down immersion, might be a vendor specific choice ?

@monsieurtanuki
Copy link
Contributor

I guess I already uninstalled gmail months ago - their UX stinks.
Regarding maps, fair enough, but they do have a large control over the screen background - like dark maps in dark mode.

Anyway, my initial point was to fix the issue quickly in a maintainable way, as always.
Other solutions are possible but cost higher in maintenance, e.g. when upgrading to material 3.

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants