Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invisible donation campaign svg file #5809

Closed
monsieurtanuki opened this issue Nov 7, 2024 · 2 comments
Closed

Invisible donation campaign svg file #5809

monsieurtanuki opened this issue Nov 7, 2024 · 2 comments

Comments

@monsieurtanuki
Copy link
Contributor

What

The donation campaign logo cannot be seen at all, as it cannot be downloaded.
E _SvgSafeNetworkState: Could really not download "https://raw.githubusercontent.com/openfoodfacts/smooth-app_assets/refs/heads/main/prod/tagline/android/assets/donation_campaign/fr.svg"
https://raw.githubusercontent.com/openfoodfacts/smooth-app_assets/refs/heads/main/prod/tagline/android/assets/donation_campaign/fr.svg

Steps to reproduce the behavior

  1. Start the app
  2. See error

Expected behavior

The svg file should be reachable through the network.
In addition to that, as there's no cached svg file (cf. #5748 being ignored), we see no svg at all, just an empty space.

Screenshot/Mockup/Before-After

No icon for the donation campaign:
Image

@g123k
Copy link
Collaborator

g123k commented Nov 7, 2024

Yes, I've updated the JSON on GitHub to change the content (text + image).
Nobody uses it yet (the prod app still depends on the server version).

To force reloading the JSON, you can do it from the DEV mode.

@monsieurtanuki
Copy link
Contributor Author

Somehow fixed.

@github-project-automation github-project-automation bot moved this from 💬 To discuss and validate to 🎊 Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants