-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open admin dashboard in same tab by default #13143
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, I agree!
Good points to consider, but as you say, it's not too hard to open in a new tab. Some users may find the change annoying, but it might be a chance for educating on standard browser functionality. So I suggest we add some tips to the release notes. Eg:
You can still open the admin interface in a new tab by holding ctrl/cmd when clicking. Or right-click/long press and choose "Open in new tab".
(that's not perfect, feel free to improve on it).
I also checked a couple of other online systems. Both Wordpress and Metabase don't open a new tab when you go to the admin interface.
From Amida:
|
thanks everyone, this is indeed a nice way to start!
Metabase is only an admin isn't, it? Regarding wordpress, most theme also allow users to edit straight on the user-facing view. So I'm not sure we can compare the use here, also I agree it's a good idea to look for inspiration. Regarding the admin link from shopfront, I think I agree with Amida: very few users (and that's confirmed by Matomo) go from the home page to the admin dashboard.
It's not when you know your keyboard shortcuts. Which our users don't. They use their mouse to do that. So it's an addition of 2 clics + you need to select the correct option. On mobile however I agree we can stick to standards more easily. Perhaps an easy way to start should be to concentrate on mobile only? |
Yes, we could. But then we have a special behaviour on just some pages. That's confusing, too. Shall I put a feature-toggle on and we experiment? |
What? Why?
Relating to recent discussions around avoiding opening links in new tabs. We want to decide this on a case by case basis. So I'm putting this forward to discuss this particular case.
We have two links from the shop menu to the admin dashboard. One is visible for desktop views in the top right corner in a menu and the other one is visible on small screens in the sidebar menu.
I find the new tab annoying. Rachel made the point that sometimes you want to have the shop and the admin panel open at the same time to see the effects of your admin actions.
People can still open tabs themselves. Do they use it? Shall we create a feature toggle for this to test? We could remove the new tab on small screens and keep it on big screens...
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates