Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align inputs on orders list and adjust position of checkboxes for reports #13156

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

drummer83
Copy link
Contributor

What? Why?

Now that we have borders around input elements since #13131, we can easily see misalignment.

This PR fixes the misalignment of input fields on the orders list and it adjusts the positions of the checkboxes for report rendering options.

Before

image

image

After

image

image

What should we test?

  • Visit /orders page.
  • Check the alignment of the input fields for filters.
  • Visit a report page which allows the setting for headers and summary rows.
  • Check the alignment of the checkboxes.
  • Check both the above for different browsers (Firefox, Chrome, Safari) and different screen sizes.

Release notes

Changelog Category (reviewers may add a label for the release notes):

  • User facing changes
  • API changes (V0, V1, DFC or Webhook)
  • Technical changes only
  • Feature toggled

The title of the pull request will be included in the release notes.

Dependencies

Documentation updates

The margin-top is not needed here. It will be added where needed in a separate commit.
Apply it only to the checkboxes on the report pages, not to one on the orders page.
@drummer83 drummer83 self-assigned this Feb 16, 2025
@drummer83 drummer83 marked this pull request as ready for review February 16, 2025 18:22
Copy link
Collaborator

@rioug rioug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, Thanks @drummer83 🙏

@rioug rioug added the user facing changes Thes pull requests affect the user experience label Feb 17, 2025
Copy link
Member

@dacook dacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that too, thanks for quickly solving it!
It's great that you solved it by making the style rules more general and simpler too 💯

It might be worth also checking any other pages with inline checkboxes too (eg editing product or order cycles maybe?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user facing changes Thes pull requests affect the user experience
Projects
Status: Test Ready 🧪
Development

Successfully merging this pull request may close these issues.

3 participants