Create styled email for reset password instructions #13157
Conversation
|
Nice 🙂 Is this also handling case 1 in openfoodfoundation/wishlist#357 ? |
|
According to my notes the language is selected properly already. I'm stuck on the failing spec currently though. 😕 |
Hmm, in different specs it gets called 'mail', 'email', 'message'. The object is a Mail::Message object. The method to generate the object is called `mail`, so I went with that.
Now that it's a multi-part email, we have to select the html part for the test. Another option is to simply check mail.to_s, but this also includes mail headers so doesn't specifically test the body.
Looks like that was solved in I've updated the bottom of the issue description to say "remaining issues list", which now implies that other cases have already been solved :) |
|
Ahhh, thank you, @dacook! |
I don't think all the other cases are covered by the remaining issues though 🙂 |
Oh, yes sorry I didn't read the whole thing. I've reverted my change. We probably need to review the whole issue to see what's still relevant. |
|
Nevermind, I'm working my way through the emails and will update the remaining issues afterwards. 👍🏻 |
mkllnk
added
the
user facing changes
What? Why?
Until now the email which was sent to users who forgot their password wasn't styled at all and it contained plain text only. To unify with our other emails I've now created a styled version of it.
Before
After
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates