Header: Improve logo, resizing and styles #13170
Open
+11
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the sites main logo instead of footer logo to allow for better contrast on gray background (dark text on gray instead of white text on gray) The table's background color is defined in the parent table already Limit the max width and max height of the logo and resize the logo accordingly instead of forcing it to squeeze into a fixed size Update specs
drummer83
added
the
user facing changes
|
We should notify instance managers about this change so they can check their logo. |
mkllnk
requested changes
Feb 26, 2025
Comment on lines
+124
to
+127
| .middle { | ||
| vertical-align: middle; | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't see this CSS class used anywhere. Did you commit this accidentally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? Why?
This is a simple improvement of our email header.
Using the site's main logo instead of the footer logo allows for better contrast on the gray header background (dark text on gray instead of white text on gray).
Before:
After:
The table's background color is defined in the parent table already, it's not needed in the header itself again.
Limit the max width and max height of the logo and resize the logo accordingly instead of forcing it to squeeze into a fixed size
Before:
After:
Update specs
What should we test?
Release notes
Changelog Category (reviewers may add a label for the release notes):
The title of the pull request will be included in the release notes.
Dependencies
Documentation updates