Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gml:AssociationAttributeGroup from appearance property type #18

Open
clausnagel opened this issue Aug 9, 2019 · 1 comment
Open

Comments

@clausnagel
Copy link
Member

The <core:appearance> property element of core:AbstractCityObjectType is currently defined such that it can carry the Appearance inline or reference it using an XLink.

Sharing appearances between city objects this way does not make much sense in my opinion. An inline property seems to be more appropriate. This might also be true for other feature properties that are strongly related to a specific city object (e.g. core:dynamizer).

@clausnagel clausnagel changed the title Remove gml:AssociationAttributeGroup from Appearance members Remove gml:AssociationAttributeGroup from appearance property type Aug 9, 2019
@clausnagel
Copy link
Member Author

clausnagel commented Aug 15, 2019

For example, I think that core:CityObjectRelationPropertyType should also be changed into an inline property. Why should a relation between feature A and B be referenced and reused by feature C?

More properties and property types:

  • volume of core:AbstractSpaceType
  • area of core:AbstractSpaceType
  • area of core:AbstractThematicSurfaceType
  • core:ImplicitGeometryPropertyType
  • ...Member of core:CityModelType
  • roomHeight of bldg:BuildingRoomType (note that AbstractConstructionType uses HeightPropertyType which is an inline property...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant