Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readthedocs action to GitHub #2737

Open
cathales opened this issue Jan 23, 2025 · 2 comments
Open

Add readthedocs action to GitHub #2737

cathales opened this issue Jan 23, 2025 · 2 comments
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) Type:Enhancement For feature requests and enhancements

Comments

@cathales
Copy link
Contributor

As discussed in #2650, a GitHub Action could be added to check that the docs can be built before merging pull requests.

There is an official repository: https://github.com/readthedocs/actions

I’m not sure if it is what we want to do.

@cathales cathales added the Component:Doc For issues in the Documentation (e.g. for README.md files) label Jan 23, 2025
@JeanRochCoulon JeanRochCoulon added the Type:Enhancement For feature requests and enhancements label Jan 23, 2025
@valentinThomazic
Copy link
Contributor

Here is what I proposed on the previous issue

There is an option in Read the Docs enabling the build on each pull request as a Github action. This would not only make debugging easier but would also prevent merging commits that break the documentation build while providing a preview of what is to be merged when the build is successful.

Here is the (read the docs) documentation about this feature: feature feature configuration

Of course, it is up to OpenHW Group to decide wether they want to do that or not, since this would trigger more builds.

@cathales
Copy link
Contributor Author

If I understand it correctly, Valentin’s suggestion does not require adding an action yaml file in the repository.
It seems to be a more robust solution as the actions repositories are not always well maintained (we already had issues with verible-format)…

However, it can only be enabled on OpenHW Group side, with an access to their ReadTheDocs account.

Would you have such an access @MikeOpenHWGroup?
Here is the link that Valentin had provided to enable this feature: https://docs.readthedocs.io/en/stable/guides/pull-requests.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component:Doc For issues in the Documentation (e.g. for README.md files) Type:Enhancement For feature requests and enhancements
Projects
None yet
Development

No branches or pull requests

3 participants