Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings not saved/loaded with scene #5

Open
ungi opened this issue Sep 8, 2012 · 2 comments
Open

Settings not saved/loaded with scene #5

ungi opened this issue Sep 8, 2012 · 2 comments

Comments

@ungi
Copy link
Contributor

ungi commented Sep 8, 2012

Users don't really tolerate long user guides.
E.g.

  • Go to VolumeResliceDriver module
  • Select the driver transform.
  • Select Position and orientation
  • Select Transverse.

This could all be eliminated from the user guide if these settings were saved.

@ungi
Copy link
Contributor Author

ungi commented Dec 27, 2012

I would like to fix this issue, but I need some advise on how to do it. The save/load with scene requires a MRML node (VolumeResliceDriverNode). But adding a MRML node selector combo-box on the GUI is a little too complicated and not needed in my opinion.

I would do the following, but I need confirmation that it's a good idea:

  • Create a default MRML node when the Logic is initialized, and use it until a scene is loaded.
  • When a new MRML node is loaded with the scene, delete the current one and replace it with the loaded one.
    The logic would take care of deleting all MRML nodes and just keep (and use) the most recent one.

Is this a good idea?

@ungi
Copy link
Contributor Author

ungi commented Dec 28, 2012

I received a good suggestion from Andras. I will try to implement this:

"By the way, if you only store information related to other nodes then you may consider storing them in the nodes, as MRML note attributes (http://www.slicer.org/slicerWiki/index.php/Documentation/Nightly/Developers/MRML#MRML_node_attributes).

e.g., you could just store these attributes in the singleton red, yellow, green slice nodes:
VolumeResliceDriver.Driver
VolumeResliceDriver.Method
VolumeResliceDriver.Orientation

It would be certainly much simpler and maybe even nicer to implement this feature with custom node attributes than introducing another singleton node for this. Especially, if the GUI remains as is, without any hint that the information is saved into a parameter node."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant