8315380: AsyncGetCallTrace crash in frame::safe_for_sender #3003
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is fixing the problem in
frame_aarch64.cpp
, functionsafe_for_sender
, where we have this codeWhile this captures one possibility of not being safe, it omits the check for
unextended_sp
falling within the stack space.The proposed change then is
This is actually just making sure the behaviour is the same as in JDK 15+ (since JDK-8238988) where the
unextended_sp
is checked for being within the stack limits.The change is not accompanied by a JTReg test because I was not able to craft one triggering the issue reliably.
Existing tests from tier1-tier4 were run on a linux-aarch64 system with no new failures observed.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3003/head:pull/3003
$ git checkout pull/3003
Update a local copy of the PR:
$ git checkout pull/3003
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3003/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3003
View PR using the GUI difftool:
$ git pr show -t 3003
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3003.diff
Using Webrev
Link to Webrev Comment