8342075: HttpClient: improve HTTP/2 flow control checks #3005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review backport of JDK-8342075
The backport is not clean:
The changes are skipped because there are no java.net.http configuration properties definitions in the file. It was added by JDK-8296804 in JDK20 but not backported.
Comments are not added into Stream::incoming() method because of no JDK-8298340 in JDK11
Fixed instance of pattern, added in JDK14
Fixed string formatting in Stream::windowSizeExceeded
manual merge because of differences in the import section caused by JDK-8308310
Added Http2Connection.java::isOpen method. It was added by 8254786 in JDK19
Changes skipped. This test was added as part of the JDK-8217264, but this functionality was not backported to JDK11
Test classes are updated from JDK-8335181 with getConnectionKey() implementation
These library classes are located in another directory (8295944 is not backported to JDK11).
Test classes are updated to use ExecutorService::shutdown method to shut down httpclient. These methods are added by JDK-8267140 in JDK21
Fixed instance of pattern, added in JDK14
Fixed build and modules dependencies
All java/net/httpclient jtreg tests are passed
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3005/head:pull/3005
$ git checkout pull/3005
Update a local copy of the PR:
$ git checkout pull/3005
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3005/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3005
View PR using the GUI difftool:
$ git pr show -t 3005
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3005.diff
Using Webrev
Link to Webrev Comment