8255466: C2 crashes at ciObject::get_oop() const+0x0 #536

sendaoYan · 2024-07-07T08:55:07Z

Hi all,
This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning hotspot/src/share/vm/opto/type.cpp:2556:71: error: ‘this’ pointer is null with gcc13.
Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add bootclasspath.
New test fails without the patch, passes with it.

Additional testing:

linux x64 tier1/2/3 jtreg test
linux aarch64 tier1/2/3 jtreg test

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8255466 needs maintainer approval
Change must be properly reviewed (2 reviews required, with at least 2 Reviewers)

Issue

JDK-8255466: C2 crashes at ciObject::get_oop() const+0x0 (Bug - P3 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)
Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/536/head:pull/536
$ git checkout pull/536

Update a local copy of the PR:
$ git checkout pull/536
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/536/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 536

View PR using the GUI difftool:
$ git pr show -t 536

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/536.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-07-07T08:55:23Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-07-07T08:55:57Z

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255466: C2 crashes at ciObject::get_oop() const+0x0

Reviewed-by: phh, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-07-07T08:56:07Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-07-07T09:00:11Z

Webrevs

sendaoYan · 2024-07-08T15:38:44Z

The GHA report several failures.

Some failures are CA issues, which is fixing by PR256. It's unrelated to this PR.

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlseccrootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#digicerttlsrsarootg5
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#quovadisrootca1g3

Linux x86 gc/concurrentMarkSweep/SystemGCOnForegroundCollector.java report crash CompactibleFreeListSpace::block_size(HeapWord const*), which has been recorded by JDK-8303159, it's unrelated to this PR.
MacOS build fail, the GHA doesn't show any fail logs, maybe it's enviromental issue, or GHA can't pick up MacOS runner.

sendaoYan · 2024-07-08T15:48:11Z

/approval request Backport JDK-8255466 to fix the corner case in C2. The change has been verified on linux x64 and linux aarch64 with jtreg tier1/2/3.

openjdk · 2024-07-08T15:49:04Z

@sendaoYan
8255466: The approval request has been created successfully.

phohensee

This backport includes a backport of JDK-8250825. Please either do that backport first, or merge it with this PR.

sendaoYan · 2024-07-24T12:33:47Z

This backport includes a backport of JDK-8250825. Please either do that backport first, or merge it with this PR.

Thanks very much for your patience and careful review. I have created a backport PR of JDK-8250825.

bridgekeeper · 2024-08-21T16:36:35Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-08-22T01:24:43Z

Wait the prefixed PR merged.
/approval cancel

openjdk · 2024-08-22T01:25:41Z

@sendaoYan
8255466: The approval request has been cancelled successfully.

bridgekeeper · 2024-09-19T03:13:54Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-09-19T03:29:08Z

Wait the prefixed #552 merged.

bridgekeeper · 2024-10-17T04:35:57Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-10-17T05:52:40Z

/open

openjdk · 2024-10-17T05:53:42Z

@sendaoYan This pull request is already open

bridgekeeper · 2024-11-14T08:03:01Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-11-14T09:01:19Z

/open

openjdk · 2024-11-14T09:02:31Z

@sendaoYan This pull request is already open

sendaoYan · 2025-01-31T06:10:33Z

Prefixed backport has been merged. Can anyone review this backport, thanks.

openjdk · 2025-01-31T14:52:25Z

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

sendaoYan · 2025-01-31T15:15:19Z

Thanks for the review @phohensee

gnu-andrew

Backport looks good.
Happy to approve this once the JDK-8349166 issue is resolved from the previous JDK-8349166 backport.

gnu-andrew · 2025-01-31T23:09:34Z

/reviewers 2 reviewer

openjdk · 2025-01-31T23:10:23Z

@gnu-andrew
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 2 Reviewers).

sendaoYan · 2025-02-01T04:48:24Z

GHA report several test failures, expect the CA issue which has been fixing by #526. Other failure shows as below:

Macos x64 'compiler/unsafe/OpaqueAccesses.java' fails 'SIGSEGV in Unsafe_GetInt', This test also fails in PR551 and fixing by 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553, it's unrelated to this PR.
Macos x64 'com/sun/jdi/PrivateTransportTest.sh' fails 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by JDK-8216265. This test also fails in 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551 unralated to this PR.
Macos x64 'sun/misc/CopyMemory.java' fails 'Unsafe_SetByte', this issue fixing by 8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553, it's unralated to this PR.

gnu-andrew

Thanks for #619 Approved

gnu-andrew · 2025-02-19T23:05:22Z

GHA report several test failures, expect the CA issue which has been fixing by #526.

#526 doesn't fix the issue. It hides it. The right solution is to fix the offending case or at least exclude it, as has been done in the past.

Other failure shows as below:

1. Macos x64 'compiler/unsafe/OpaqueAccesses.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461702188) 'SIGSEGV  in Unsafe_GetInt', This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551) and fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.

2. Macos x64 'com/sun/jdi/PrivateTransportTest.sh' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'JDWP exit error AGENT_ERROR_TRANSPORT_LOAD(196): No transports initialized', which recorded by [JDK-8216265](https://bugs.openjdk.org/browse/JDK-8216265). This test also fails in [8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory #551](https://github.com/openjdk/jdk8u-dev/pull/551) unralated to this PR.

3. Macos x64 'sun/misc/CopyMemory.java' [fails](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/13067155994/job/36461701888) 'Unsafe_SetByte', this issue fixing by [8186787: clang-4.0 SIGSEGV in Unsafe_PutByte #553](https://github.com/openjdk/jdk8u-dev/pull/553), it's unrelated to this PR.

Thanks for tracking these down. I didn't realise they all had PRs. I'll try and look over them tomorrow.

sendaoYan · 2025-02-20T02:46:14Z

/approval request Backport to fix the corner case in C2, this backport also fix a compiler warning build with gcc13. Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add bootclasspath. New test fails without the patch, passes with it. Jtreg tests locally shows no regress with this patch.

openjdk · 2025-02-20T02:46:45Z

@sendaoYan
8255466: The approval request has been created successfully.

gnu-andrew · 2025-02-20T09:11:34Z

/approve yes

openjdk · 2025-02-20T09:11:55Z

@gnu-andrew
8255466: The approval request has been approved.

sendaoYan · 2025-02-20T09:26:33Z

Thanks @gnu-andrew

/integrate

openjdk · 2025-02-20T09:26:57Z

@sendaoYan
Your change (at version f00511f) is now ready to be sponsored by a Committer.

gnu-andrew · 2025-02-20T10:54:39Z

/sponsor

openjdk · 2025-02-20T10:55:42Z

Going to push as commit fc88d51.
Since your change was applied there have been 2 commits pushed to the master branch:

88a7829: 8339644: Improve parsing of Day/Month in tzdata rules
4c50940: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

Your commit was automatically rebased without conflicts.

openjdk · 2025-02-20T10:55:50Z

@gnu-andrew @sendaoYan Pushed as commit fc88d51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport bb3f1238cb12c45ed85936d3b06eced0730d588f

95f3242

openjdk bot changed the title ~~Backport bb3f1238cb12c45ed85936d3b06eced0730d588f~~ 8255466: C2 crashes at ciObject::get_oop() const+0x0 Jul 7, 2024

openjdk bot added backport rfr Pull request is ready for review labels Jul 7, 2024

openjdk bot added the approval label Jul 8, 2024

phohensee suggested changes Jul 23, 2024

View reviewed changes

sendaoYan mentioned this pull request Jul 24, 2024

8250825: C2 crashes with assert(field != __null) failed: missing field #552

Closed

6 tasks

This was referenced Aug 19, 2024

8329826: GCC 12 reports some compiler error when building jdk8 #479

Closed

8281096: Flags introduced by configure script are not passed to ADLC build #357

Closed

openjdk bot removed the approval label Aug 22, 2024

sendaoYan requested a review from phohensee November 19, 2024 08:19

Add a whitespace

f00511f

phohensee approved these changes Jan 31, 2025

View reviewed changes

gnu-andrew reviewed Jan 31, 2025

View reviewed changes

gnu-andrew approved these changes Feb 19, 2025

View reviewed changes

openjdk bot added the approval label Feb 20, 2025

openjdk bot added ready Pull request is ready to be integrated and removed approval labels Feb 20, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 20, 2025

openjdk bot added the integrated Pull request has been integrated label Feb 20, 2025

openjdk bot closed this Feb 20, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 20, 2025

sendaoYan deleted the jbs8255466 branch February 20, 2025 12:02

8255466: C2 crashes at ciObject::get_oop() const+0x0 #536

8255466: C2 crashes at ciObject::get_oop() const+0x0 #536

Conversation

sendaoYan commented Jul 7, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 7, 2024

openjdk bot commented Jul 7, 2024 • edited Loading

openjdk bot commented Jul 7, 2024

mlbridge bot commented Jul 7, 2024 • edited Loading

Webrevs

sendaoYan commented Jul 8, 2024 • edited Loading

sendaoYan commented Jul 8, 2024

openjdk bot commented Jul 8, 2024

phohensee left a comment

Choose a reason for hiding this comment

sendaoYan commented Jul 24, 2024

bridgekeeper bot commented Aug 21, 2024

sendaoYan commented Aug 22, 2024

openjdk bot commented Aug 22, 2024

bridgekeeper bot commented Sep 19, 2024

sendaoYan commented Sep 19, 2024

bridgekeeper bot commented Oct 17, 2024

sendaoYan commented Oct 17, 2024

openjdk bot commented Oct 17, 2024

bridgekeeper bot commented Nov 14, 2024

sendaoYan commented Nov 14, 2024

openjdk bot commented Nov 14, 2024

sendaoYan commented Jan 31, 2025

openjdk bot commented Jan 31, 2025

sendaoYan commented Jan 31, 2025

gnu-andrew left a comment

Choose a reason for hiding this comment

gnu-andrew commented Jan 31, 2025

openjdk bot commented Jan 31, 2025

sendaoYan commented Feb 1, 2025

gnu-andrew left a comment

Choose a reason for hiding this comment

gnu-andrew commented Feb 19, 2025

sendaoYan commented Feb 20, 2025

openjdk bot commented Feb 20, 2025

gnu-andrew commented Feb 20, 2025

openjdk bot commented Feb 20, 2025

sendaoYan commented Feb 20, 2025

openjdk bot commented Feb 20, 2025

gnu-andrew commented Feb 20, 2025

openjdk bot commented Feb 20, 2025

openjdk bot commented Feb 20, 2025

sendaoYan commented Jul 7, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jul 7, 2024 •

edited

Loading

mlbridge bot commented Jul 7, 2024 •

edited

Loading

sendaoYan commented Jul 8, 2024 •

edited

Loading