8250825: C2 crashes with assert(field != __null) failed: missing field #552

sendaoYan · 2024-07-24T12:28:49Z

Hi all,
This is backport of JDK-8250825. It's prefixed PR for JDK-8255466 backport.
New test fails without the patch, passes with it.

There are two parts make this backport not clean:

Patch does not apply cleanly due to different context, before JDK-8250825 the PR JDK-8230505 change releated lines, and I think JDK-8230505 do not needed backport to jdk8u-dev.
The added testcase can't backport to jdk8u directly, import jdk.internal.misc.Unsafe should instead of import sun.misc.Unsafe in jdk8u.

Additional testing:

linux x64 tier1/2/3 jtreg test
inux aarch64 tier1/2/3 jtreg test

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8250825 needs maintainer approval

Issue

JDK-8250825: C2 crashes with assert(field != __null) failed: missing field (Bug - P3 - Approved)

Reviewers

Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/552/head:pull/552
$ git checkout pull/552

Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 552

View PR using the GUI difftool:
$ git pr show -t 552

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/552.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2024-07-24T12:29:16Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-07-24T12:29:39Z

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250825: C2 crashes with assert(field != __null) failed: missing field

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

492acd3: 8265019: Update tests for additional TestNG test permissions
3683a81: Merge
129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
c2f7e61: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
2d042cf: 8336564: Enhance mask blit functionality redux
1a447c7: 8335428: Enhanced Building of Processes
1a6e3a5: 8342822: jdk8u432-b06 does not compile on AIX
5a4b440: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
d407d63: 8345504: Bump update version of OpenJDK: 8u452
2931b1d: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F
... and 82 more: https://git.openjdk.org/jdk8u-dev/compare/c8d52b07e18552105d653667e003c566db33e5dc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-07-24T12:29:55Z

This backport pull request has now been updated with issue from the original commit.

mlbridge · 2024-07-24T12:34:01Z

Webrevs

01: Full - Incremental (f0bba3ee)
00: Full (7f528207)

phohensee

The new test fails GHA.

sendaoYan · 2024-07-25T01:51:00Z

The new test fails GHA.

Yes, that's the reason this PR still in Draft status, I will fix the test these days.

openjdk · 2024-07-25T03:15:48Z

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

sendaoYan · 2024-07-25T03:17:47Z

After the additional test finish, I will make approval request.

sendaoYan · 2024-07-25T03:21:29Z

The new test fails GHA.

The test fails has been fixed now.

sendaoYan · 2024-07-25T08:35:13Z

The GHA report several failures:

macos x64 runtime/7158988/FieldMonitor.java fails VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification. This test also fails in PR551, I think it's unrelated to this PR.
macos x64 compiler/unsafe/OpaqueAccesses.java fails SIGSEGV in Unsafe_GetInt, This test also fails in PR551, I think it's unrelated to this PR.
macos x64 all the com/sun/jdi testcases fails transport error 202: gethostbyname: unknown host, seems to be GHA environmental issue.

sendaoYan · 2024-07-25T08:48:35Z

/approval request Backport JDK-8250825, New test fails without the patch, passes with it. All the jtreg tests on linux x86_64 and aarch64 shows no new failure.

openjdk · 2024-07-25T08:49:24Z

@sendaoYan
8250825: The approval request has been created successfully.

zzambers · 2024-07-25T10:23:36Z

The GHA report several failures:

1. macos x64 `runtime/7158988/FieldMonitor.java` fails `VM initialization failed for: j2sdk-image/jre/bin/java -Xshare:off -XX:+PrintGC -Xdebug -Xrunjdwp:transport=dt_socket,address=Mac-1721876641775.local:49199,suspend=y TestPostFieldModification`. This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.

2. macos x64 `compiler/unsafe/OpaqueAccesses.java` fails `SIGSEGV  in Unsafe_GetInt`, This test also fails in [PR551](https://github.com/openjdk/jdk8u-dev/pull/551), I think it's unrelated to this PR.

3. macos x64 all the `com/sun/jdi` testcases fails `transport error 202: gethostbyname: unknown host`, seems to be GHA environmental issue.

All these mac issues should be unrelated, see: #544

sendaoYan · 2024-07-25T12:21:33Z

After #544 has been merged, does the two jbs issue can be cloesd? @zzambers
https://bugs.openjdk.org/browse/JDK-8337185
https://bugs.openjdk.org/browse/JDK-8337183

sendaoYan · 2024-07-25T15:13:37Z

Thanks for the review.

zzambers · 2024-07-25T15:16:13Z

After #544 has been merged, does the two jbs issue can be cloesd? @zzambers
https://bugs.openjdk.org/browse/JDK-8337185
https://bugs.openjdk.org/browse/JDK-8337183

I have classified problems on MacOS in this coment: #544 (comment)

openjdk · 2024-09-19T03:35:18Z

@sendaoYan
8250825: The approval request has been updated successfully.

bridgekeeper · 2024-10-17T04:34:15Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-10-17T05:52:11Z

/approval request Fixes the corner case in C2. Patch does not apply cleanly due to different context. New test fails without the patch, passes with it. jtreg tier{1,2,3,etc.} also passes on linux x86_64 and linux aarch64.

openjdk · 2024-10-17T05:52:44Z

@sendaoYan
8250825: The approval request has been updated successfully.

bridgekeeper · 2024-11-14T08:01:00Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-11-14T09:01:04Z

/open

openjdk · 2024-11-14T09:01:28Z

@sendaoYan This pull request is already open

bridgekeeper · 2024-12-12T14:27:30Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2024-12-12T15:12:32Z

/open

openjdk · 2024-12-12T15:13:27Z

@sendaoYan This pull request is already open

bridgekeeper · 2025-01-09T18:34:52Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2025-01-30T03:22:17Z

Thanks for the approved.

/integrate

openjdk · 2025-01-30T03:23:00Z

@sendaoYan
Your change (at version f0bba3e) is now ready to be sponsored by a Committer.

phohensee · 2025-01-30T15:15:36Z

/sponsor

openjdk · 2025-01-30T15:17:04Z

Going to push as commit 8b08668.
Since your change was applied there have been 94 commits pushed to the master branch:

bfd4d8b: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo
f89c26f: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java
492acd3: 8265019: Update tests for additional TestNG test permissions
3683a81: Merge
129290d: 8339180: Enhanced Building of Processes: Follow-on Issue
c2f7e61: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
2d042cf: 8336564: Enhance mask blit functionality redux
1a447c7: 8335428: Enhanced Building of Processes
1a6e3a5: 8342822: jdk8u432-b06 does not compile on AIX
5a4b440: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files
... and 84 more: https://git.openjdk.org/jdk8u-dev/compare/c8d52b07e18552105d653667e003c566db33e5dc...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-30T15:17:12Z

@phohensee @sendaoYan Pushed as commit 8b08668.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

sendaoYan · 2025-01-30T15:25:46Z

Thanks for the sponsor.

gnu-andrew · 2025-01-31T22:07:43Z

Why has this been pushed when the whitespace issue I raised has still not been resolved?

$ diff -u ../jdk11u-dev/src/hotspot/share/opto/type.cpp hotspot/src/share/vm/opto/type.cpp|grep basic_elem
             BasicType basic_elem_type = field->layout_type();
             _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT ||
-                                                         basic_elem_type == T_ARRAY);
+                                                       basic_elem_type == T_ARRAY);

gnu-andrew · 2025-01-31T22:47:04Z

@sendaoYan I have opened JDK-8349166 and assigned it to you. Please correct this issue.

sendaoYan · 2025-02-01T03:28:06Z

@sendaoYan I have opened JDK-8349166 and assigned it to you. Please correct this issue.

Thanks for the patient reviews. I will look the indentation issue as soon as possible.

Backport e03ca73dc122af84d4a5456120e5cf5fac7aed31

7f52820

openjdk bot changed the title ~~Backport e03ca73dc122af84d4a5456120e5cf5fac7aed31~~ 8250825: C2 crashes with assert(field != __null) failed: missing field Jul 24, 2024

openjdk bot added backport rfr Pull request is ready for review labels Jul 24, 2024

sendaoYan mentioned this pull request Jul 24, 2024

8255466: C2 crashes at ciObject::get_oop() const+0x0 #536

Closed

6 tasks

sendaoYan marked this pull request as draft July 24, 2024 12:40

openjdk bot removed the rfr Pull request is ready for review label Jul 24, 2024

phohensee approved these changes Jul 24, 2024

View reviewed changes

phohensee reviewed Jul 24, 2024

View reviewed changes

implement Unsafe.getUnsafe() in jdk8u

f0bba3e

sendaoYan marked this pull request as ready for review July 25, 2024 03:14

openjdk bot added the rfr Pull request is ready for review label Jul 25, 2024

openjdk bot added the approval label Jul 25, 2024

phohensee approved these changes Jul 25, 2024

View reviewed changes

zzambers mentioned this pull request Aug 19, 2024

8329826: GCC 12 reports some compiler error when building jdk8 #479

Closed

4 tasks

openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 30, 2025

openjdk bot added the integrated Pull request has been integrated label Jan 30, 2025

openjdk bot closed this Jan 30, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 30, 2025

sendaoYan deleted the jbs8250825 branch January 30, 2025 15:25

sendaoYan mentioned this pull request Feb 1, 2025

8349166: Bad indentation in backport of JDK-8250825 #619

Closed

4 tasks

8250825: C2 crashes with assert(field != __null) failed: missing field #552

8250825: C2 crashes with assert(field != __null) failed: missing field #552

Conversation

sendaoYan commented Jul 24, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

bridgekeeper bot commented Jul 24, 2024

openjdk bot commented Jul 24, 2024 • edited Loading

openjdk bot commented Jul 24, 2024

mlbridge bot commented Jul 24, 2024 • edited Loading

Webrevs

phohensee left a comment

Choose a reason for hiding this comment

sendaoYan commented Jul 25, 2024 • edited Loading

openjdk bot commented Jul 25, 2024

sendaoYan commented Jul 25, 2024

sendaoYan commented Jul 25, 2024

sendaoYan commented Jul 25, 2024

sendaoYan commented Jul 25, 2024

openjdk bot commented Jul 25, 2024

zzambers commented Jul 25, 2024

sendaoYan commented Jul 25, 2024

sendaoYan commented Jul 25, 2024

zzambers commented Jul 25, 2024

openjdk bot commented Sep 19, 2024

bridgekeeper bot commented Oct 17, 2024

sendaoYan commented Oct 17, 2024

openjdk bot commented Oct 17, 2024

bridgekeeper bot commented Nov 14, 2024

sendaoYan commented Nov 14, 2024

openjdk bot commented Nov 14, 2024

bridgekeeper bot commented Dec 12, 2024

sendaoYan commented Dec 12, 2024

openjdk bot commented Dec 12, 2024

bridgekeeper bot commented Jan 9, 2025

sendaoYan commented Jan 30, 2025

openjdk bot commented Jan 30, 2025

phohensee commented Jan 30, 2025

openjdk bot commented Jan 30, 2025

openjdk bot commented Jan 30, 2025

sendaoYan commented Jan 30, 2025

gnu-andrew commented Jan 31, 2025

gnu-andrew commented Jan 31, 2025

sendaoYan commented Feb 1, 2025 • edited Loading

sendaoYan commented Jul 24, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jul 24, 2024 •

edited

Loading

mlbridge bot commented Jul 24, 2024 •

edited

Loading

sendaoYan commented Jul 25, 2024 •

edited

Loading

sendaoYan commented Feb 1, 2025 •

edited

Loading