8350816: [8u] Update TzdbZoneRulesCompiler to ignore HST/EST/MST links #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 8u-specific issue. It's a prerequisite for backport of 2024b (JDK-8339637) as backporting 2024b to 8u as is leads to the following failure
java.lang.IllegalArgumentException: Unknown region: HST
at build.tools.tzdb.TzdbZoneRulesCompiler.findRegionIndex(TzdbZoneRulesCompiler.java:290)
at build.tools.tzdb.TzdbZoneRulesCompiler.outputFile(TzdbZoneRulesCompiler.java:259)
at build.tools.tzdb.TzdbZoneRulesCompiler.compile(TzdbZoneRulesCompiler.java:193)
at build.tools.tzdb.TzdbZoneRulesCompiler.main(TzdbZoneRulesCompiler.java:91)
JDK-8042369 updated the compiler to ignore HST/EST/MST links in 9+ (https://hg.openjdk.org/jdk9/jdk9/jdk/rev/6c26f18d9bc0#l8.139) so the failure didn't appear with backports of 2024b to 11+
The patch changes the compiler in 8u to ignore HST/EST/MST links and work in the same way as it works for 11+
Testing: all relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/630/head:pull/630
$ git checkout pull/630
Update a local copy of the PR:
$ git checkout pull/630
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/630/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 630
View PR using the GUI difftool:
$ git pr show -t 630
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/630.diff
Using Webrev
Link to Webrev Comment