Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address: use Downshift because it's awesome. #108

Open
jtrein opened this issue Feb 12, 2020 · 1 comment
Open

Address: use Downshift because it's awesome. #108

jtrein opened this issue Feb 12, 2020 · 1 comment
Assignees
Labels

Comments

@jtrein
Copy link
Contributor

jtrein commented Feb 12, 2020

Autosuggest needs updates, and I'd prefer rather than to continue using it to use a newer take on autosuggest boxes, https://github.com/downshift-js/downshift.

We already use it for the Address component inside of LAO front-end app and it's easier to configure and set default "searching" text than what I've hacked together in Autosuggest.

Autosuggest also needs some package updates to stop some React warnings and the maintainer has been slow to update anything around this. Time to use a more up-to-date lib.

@jtrein jtrein self-assigned this Feb 12, 2020
@jtrein
Copy link
Contributor Author

jtrein commented Feb 12, 2020

Testing should be much easier as well. The address component is a bit of a pain to test with Autosuggest. Downshift also helps with usability; I had to customize some things in the behaviours of Autosuggest to get it be usable with our multiple async actions (searching then creating an address).

@jtrein jtrein added the refactor label Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant