-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AgroPortal Hackathon #36
Comments
Hi Andon
@antleb Could you also please check the technical details and see if the XML files can be imported to the registry as required? |
@pennyl67 looks as if some XML elements have disappeared from at least the first bullet point? |
|
@greenwoodma you are right! Thanks for noticing!
|
@pennyl67 For number 2, I think the best option would be to remove the contextPerson entry altogether in the case where the value supplied for email is invalid. I will make the changes, deploy the updated adapter code and notify you here when it's done |
Hello all, sorry for being late, thanks @twktheainur for reporting on our project. To come back on point 2: whatever we decide, the key aspect if to go down to the ontology contact person to actually let them know they should correct the metadata. I think this is ok to say to someone uploading an ontology to one of the 4 repositories: if you fill in this ans this more carefully, your ontology will be available also in the OMTD platform. As of producing the final deliverables (T3, D4 and T4) we will do it offline as official PDF documents referring to the GitHub project (https://github.com/agroportal/ncboproxy) in the case of T3. On our side, we still need to: |
@pennyl67 I have made the corrections. I am attaching a full metadata export for all ontologies on SIFR BioPortal (29 ontologies), AgroPortal (98 ontologies), BiblioPortal (26 ontologies) and NCBO BioPortal (779 ontologies) Agroportal_ontologies_omtd-share_metadata-16_04_2018-20_20.zip |
@twktheainur
|
Thank you for the feedback @pennyl67. Yesterday I noticed that the openminted project group on github had an omtd-model maven project that is available on maven central and that also creates a JAXB binding of the XSD specification in exactly the same manner as our implementation. Consequently, I have included omtd-model as a dependency of our implementation and replaced our jaxb bindings. This should improve maintainability when future versions of the specifications are released. |
Thanks @twktheainur! |
@twktheainur When you have the updated metadata records for the ontologies, could you upload them again for the final check? Thanks! |
@pennyl67 Here are the updated metadata records for the 4 portals. Agroportal_ontologies_omtd-share_metadata-19_04_2018-13_34.zip I tried to submit a few ontologies on the test platform directly from the URL of our API call rather than by copy pasting the XML, as it is the intended role of that API, which seems to be working fine |
I've run the validation test again and I get the following errors:
|
Apologies, it appears my initial reply did no go through and remained unposted, which I have realised just now @pennyl67 Some issues were introduced when I switched to using omtd-model as a dependency after the previous round of fixes. I have debugged the issues, the output should now be ok. Concerning the TEST23 ontology, I believe it is a test ontology that someone submitted to the portal publicly. There is also a TEST ontology. Given that anyone can submit content to biblioportal and that most users are not technologically savvy, such errors are more prone to happen on biblioportal, however it is not excluded the same could happen on the other portals too. All I can do in this care is notify the people in NCBO so that they can address the issue. Agroportal_ontologies_omtd-share_metadata-19_04_2018-16_58.zip |
Just reported to delete TEST ontology from BiblioPortal and enter correct information for Contact info (name+email) |
Thanks @jonquet and @twktheainur |
Hi @twktheainur I only found three invalid records (DOCC, NCC, and NCCO in the NCBIO portal. Again, the empty contactInfo problem - maybe some files were not parsed with the suggested solution (i.e. using the resourceIdentifier)? |
@pennyl67 Thank you for the feedback, a corner case wasn't handled properly. I have pushed a fix. I am attaching the corrected version of the three incriminated records |
@twktheainur Thanks! Then all the files are now valid. |
Dear OpenMinted Team,
Our implementation is concluded and we were already given feedback on the metadata we produce for the Agroportal, SIFR Bioportal, NCBO Bioportal and Biblioportal ontologies by Penny. We integrated the suggested changes. Please note that the submissions made on the test platform were prior to our integration of the changes resulting from the feedback on the metadata.
I am creating this issue for a final check. Everything is working, including future milestones (Biblioportal and NCBO Bioportal support, although for NCBO Bioportal the api call to retrieve all ontology metadata at once does not function due to a server timeout outside of our control).
For the final deliverable, we have a gihub project (https://github.com/agroportal/ncboproxy), with a detailed readme explaining the general architecture, some details about the OMTD-Share adaptation specifically, deployment instructions (although the API is based on the production web-services and will not require any deployment on the part of the OpenMinted team) and a Javadoc documentation.
Do you think the level of detail is sufficient, so that the content of the gihub project may be used as the last deliverable in full? Otherwise, we can produce a standalone PDF document reprising this information. In the latter case, should we include a full printout of the code (as the instructions appear to suggest) or would a link to the GitHub project suffice?
I am also including some metadata outputs for Agroportal, SIFR Bioportal, NCBO Bioportal and Biblioportal for your reference:
AgroportalSample.zip
SIFRBioportalSample.zip
BiblioportalSample.zip
NCBOBioportalSamples.zip
Best Regards,
On behalf of the AgroPortal team,
Andon Tchechmedjiev
The text was updated successfully, but these errors were encountered: