Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar hides header on Firefox #679

Open
PGijsbers opened this issue Apr 17, 2019 · 4 comments
Open

Navbar hides header on Firefox #679

PGijsbers opened this issue Apr 17, 2019 · 4 comments

Comments

@PGijsbers
Copy link
Collaborator

PGijsbers commented Apr 17, 2019

When loading a documentation page on a specific header in Firefox, e.g. usage#basic-usage, when coming from a different page, the navbar hides the section header.


usage#basic-usage shows as:
image


I expect usage#basic-usage shows as:
image


The behavior seems to work correctly on Chrome.
When moving between section headers on the same page, it also seems to work fine on Firefox.

I tried to apply this fix, but it did not seem to help (though I can't guarantee I did that right).

Using Firefox 66.0.3 (64-bit).

@nok
Copy link

nok commented Apr 29, 2019

For me it works like expected in Chrome and FF.

Screenshot 2019-04-29 at 21 56 44

@mfeurer
Copy link
Collaborator

mfeurer commented Apr 30, 2019

I just tried again and it works in Chromium, but not in FF. FF only works if I narrow the window a bit. @nok shouldn't the heading at the top be 'basic usage'?

@nok
Copy link

nok commented Apr 30, 2019

It depends how it's implemented. Either you use the basic anchor tag #id or scrollTo() in JavaScript. In general you use the static variant as fallback. However it's not a critical behaviour.

@PGijsbers
Copy link
Collaborator Author

From your screenshot it seems to have skipped even more of the page?
Following the link in the original post should leave you at the top of the page exactly, having the 'Basic Usage' title fully visible (note that after opening the site, if I switch between headers in the sidebar, 'Basic Usage' will be displayed correctly, it is only on following the link the first time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants