Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After removing Reviewed Flag, Review Comments are included in complete Trial Safety Review Report #159

Open
vanguyen317 opened this issue Jan 21, 2025 · 1 comment
Open

After removing Reviewed Flag, Review Comments are included in complete Trial Safety Review Report #159

vanguyen317 opened this issue Jan 21, 2025 · 1 comment
Labels
enhancement New feature or request

Comments

@vanguyen317
Copy link
Collaborator

When saving a review with a comment and then removing the review flag afterwards, the review comment is still displayed on the review page as well in the complete Trial Safety Review Report

Image Image
Image
@LDSamson LDSamson added the enhancement New feature or request label Jan 23, 2025
@LDSamson
Copy link
Collaborator

@vanguyen317 Thanks for reporting this. I think it is not a big problem, but it can definitely be improved.
The issue is not there anymore in the current dev branch since the backend code has changed.
I will leave this issue report open until the issue is also resolved in main.

Also, I will check if we can capture the intended behavior in a simple unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LDSamson @vanguyen317