Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/create icons for the substation plugin #1229

Closed
juancho0202 opened this issue Apr 5, 2023 · 16 comments · Fixed by #1495
Closed

Update/create icons for the substation plugin #1229

juancho0202 opened this issue Apr 5, 2023 · 16 comments · Fixed by #1495
Assignees
Labels

Comments

@juancho0202
Copy link
Contributor

juancho0202 commented Apr 5, 2023

Is your feature request related to a problem? Please describe.
As a user of OpenSCD, particularly of the Substation plugin, I want to have a clear way to differentiate in the screen at the root level which elements are Substations and which are Lines or Processes.

Describe the solution you'd like
I would like to see the elements Substation, Line and Process to appear in the Substation plugin with an icon similar to the one that for example the PowerTransformer elements have:

image

Acceptance criteria

Background:
Technical approach: Copy paste the SVG of the linked icon in this issue and put it in the package/open-scd/src/icons/icons.ts folder.

@github-actions
Copy link
Contributor

Hello there,

Thank you for opening this issue! We appreciate your interest in our project.
However, it seems that this issue hasn't had any activity for a while. To ensure that our issue tracker remains organized and efficient, we occasionally review and address stale issues.

If you believe this issue is still relevant and requires attention, please provide any additional context, updates, or details that might help us understand the problem better.
Feel free to continue the conversation here.

If the issue is no longer relevant, you can simply close it. If you're uncertain, you can always reopen it later.

Remember, our project thrives on community contributions, and your input matters. We're here to collaborate and improve.
Thank you for being part of this journey!

@github-actions github-actions bot added the stale label Aug 31, 2023
@Sander3003
Copy link
Member

The issue is still relevant, it can be fixed one day!

@github-actions github-actions bot removed the stale label Sep 1, 2023
@juancho0202
Copy link
Contributor Author

@juancho0202
Copy link
Contributor Author

juancho0202 commented Dec 6, 2023

Technical approach: Copy paste the SVG of the linked icon in this issue and put it in the package/open-scd/src/icons/icons.ts file.

@Sander3003
Copy link
Member

https://github.com/ca-d/oscd-designer/blob/main/icons.ts can be a source as well. This is in investigation.

@Sander3003
Copy link
Member

Investigation from Pascal: https://codepen.io/pascalwilbrink/full/gOEWKmy

@Sander3003
Copy link
Member

Powertransformer is theire:
image

@Sander3003
Copy link
Member

Winding is missing:
image

@Sander3003
Copy link
Member

Sander3003 commented Jan 31, 2024

Requests:

Reuse the substation icon already used in OpenSCD (no design needed)

Make a material design like icon's based on the following examples:

Bay:
image

Voltage level:
image

Winding:
image

Proces:
https://www.flaticon.com/free-icon/process_2041633?term=process&page=1&position=25&origin=style&related_id=2041633

Line:
image

Source for some of the icons:
https://github.com/ca-d/oscd-designer/blob/main/icons.ts

@JakobVogelsang
Copy link
Collaborator

Jan was so kind and offered to also take a look at our primary apparatus icons that are:

Circuit breaker:
grafik

disconnector:
grafik

Earth switch:
grafik

Current transformer:
grafik

Voltage transformer:
grafik

General primary apparatus:
grafik (I think this is material already but maybe Jan can think of a better one)

@JanDietvorst
Copy link

JanDietvorst commented Mar 12, 2024

Hi all,
Here are all the icons as shown above. I discussed everything with Jakob. If there is a need for more icons in the future please let me know. I'm happy to help!
J

IC_Bay 24px

IC_Bay 24px

IC_Bay 48px

IC_Bay 48px

IC_Circuitbraker 24px

IC_Circuitbraker 24px

IC_Circuitbraker 48px

IC_Circuitbraker 48px

IC_Current transformer 24px

IC_Current transformer 24px

IC_Current transformer 48px

IC_Current transformer 48px

IC_Disconnector 24px

IC_Disconnector 24px

IC_Disconnector 48px

IC_Disconnector 48px

IC_Earth switch 24px

IC_Earth switch 24px

IC_Earth switch 48px

IC_Earth switch 48px

IC_General primary aparatus 2C 24px

IC_General primary aparatus 2C 24px

IC_General primary aparatus 2C 48px

IC_General primary aparatus 2C 48px

IC_General primary aparatus 3C 24px

IC_General primary aparatus 3C 24px

IC_General primary aparatus 3C 48px

IC_General primary aparatus 3C 48px

IC_Line 24px

IC_Line 24px

IC_Line 48px

IC_Line 48px

IC_Power transformer 24px

IC_Power transformer 24px

IC_Power transformer 48px

IC_Power transformer 48px

IC_Powerline 24px

IC_Powerline 24px

IC_Powerline 48px

IC_Powerline 48px

IC_Process 24px

IC_Process 24px

IC_Process 48px

IC_Process 48px

IC_Substation 24px

IC_Substation 24px

IC_Substation 48px

IC_Substation 48px

IC_Voltage level 24px

IC_Voltage level 24px

IC_Voltage level 48px

IC_Voltage level 48px

IC_Voltage transformer 24px

IC_Voltage transformer 24px

IC_Voltage transformer 48px

IC_Voltage transformer 48px

IC_Winding 24px

IC_Winding 24px

IC_Winding 48px

IC_Winding 48px

@Sander3003
Copy link
Member

Thanks @JanDietvorst!

@juancho0202
Copy link
Contributor Author

Hey @JanDietvorst we would appreciate if you added the name of each icon and a short description of how they are meant to be used. Thanks!

@JanDietvorst
Copy link

Hi @juancho0202 i've added the svg's of the icons above. The name of each svg contains the meaning of the icon. Also the use is in the name 24 or 48px.

@juancho0202
Copy link
Contributor Author

@Sander3003 we have decided during refinement that we will not use the IC_Powerline icon for the Line element but we'll stick with the IC_Line one. Also from the two options for general equipment we have chosen the 2C option.

@juancho0202 juancho0202 changed the title Add icons for Substation, Line and Process elements Update/create icons for the substation plugin Mar 27, 2024
@juancho0202 juancho0202 added this to Next Apr 3, 2024
@juancho0202 juancho0202 moved this to Todo in Next Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
6 participants