Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Missing documentation for search_pipelines in NodesInfo request section #6544

Open
1 of 4 tasks
lukas-vlcek opened this issue Feb 29, 2024 · 5 comments
Open
1 of 4 tasks
Assignees
Labels
search-and-query Issue: Issues related to search and query features

Comments

@lukas-vlcek
Copy link
Contributor

lukas-vlcek commented Feb 29, 2024

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.

There seems to be missing documentation for search_pipelines metric parameter in https://opensearch.org/docs/latest/api-reference/nodes-apis/nodes-info/

At least according to code there is such a metric in NodesInfoRequest.Metric enum and public NodeInfo info() in NodeService handles such parameter.

Cc: @msfroh

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

n/a

@msfroh
Copy link
Contributor

msfroh commented Feb 29, 2024

Yup.... this was a miss on my part when the search pipelines feature was added.

It was added to NodesInfo more so that nodes could coordinate amongst themselves (refusing to create a search pipeline unless all data nodes have the relevant processors installed). I forgot that NodesInfo is also user-visible.

@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented Feb 29, 2024

The thing is that with the change being introduced here I also wanted to provide documentation update. Are you fine with me adding the missing search_pipeline parameter to NodesInfo doc and marking it as not included in the default set of "metrics"?
(Although I think this should be two separated documentation PRs: one to add the search_pipelines parameter, second making it non default)

@msfroh
Copy link
Contributor

msfroh commented Feb 29, 2024

That change isn't going to be backported to 2.x because it's a breaking change, right?

In that case, for now, the doc change should just be to add the parameter I think.

Doc team, how are we planning to handle eventual 3.0 docs? I've kind of assumed that we're treating that as a "worry about it tomorrow problem" (but I like procrastinating).

@lukas-vlcek
Copy link
Contributor Author

@msfroh There are two parts.

  1. Missing search_pipelines parameter in the docs. When added it is relevant to 2.x as well, so it should be beckported if I understand correctly (I am also not sure what is the versioning story for docs).
  2. Taking search_pipelines out of the default set of "metrics" (which will apply to some other "metrics" added in the future too, like node_analyzers). This will not go to 2.x.

That is why I talk about two PRs ... but again, I am not sure about the versioning strategy for docs at the moment.

@hdhalter
Copy link
Contributor

Hi @lukas-vlcek , @msfroh , agreed, It sounds like two different PRs. We are updating the documentation for only the latest version of 2.x, which currently is 2.12. So, we can update the search_pipelines parameter there. can also create PRs for future (e.g., 3.0) documentation and just label it as 3.0 so we know not to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search-and-query Issue: Issues related to search and query features
Projects
None yet
Development

No branches or pull requests

3 participants