-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Missing documentation for search_pipelines in NodesInfo request section #6544
Comments
Yup.... this was a miss on my part when the search pipelines feature was added. It was added to NodesInfo more so that nodes could coordinate amongst themselves (refusing to create a search pipeline unless all data nodes have the relevant processors installed). I forgot that NodesInfo is also user-visible. |
The thing is that with the change being introduced here I also wanted to provide documentation update. Are you fine with me adding the missing |
That change isn't going to be backported to 2.x because it's a breaking change, right? In that case, for now, the doc change should just be to add the parameter I think. Doc team, how are we planning to handle eventual 3.0 docs? I've kind of assumed that we're treating that as a "worry about it tomorrow problem" (but I like procrastinating). |
@msfroh There are two parts.
That is why I talk about two PRs ... but again, I am not sure about the versioning strategy for docs at the moment. |
Hi @lukas-vlcek , @msfroh , agreed, It sounds like two different PRs. We are updating the documentation for only the latest version of 2.x, which currently is 2.12. So, we can update the search_pipelines parameter there. can also create PRs for future (e.g., 3.0) documentation and just label it as 3.0 so we know not to merge it. |
What do you want to do?
Tell us about your request. Provide a summary of the request and all versions that are affected.
There seems to be missing documentation for
search_pipelines
metric parameter in https://opensearch.org/docs/latest/api-reference/nodes-apis/nodes-info/At least according to code there is such a metric in
NodesInfoRequest.Metric
enum andpublic NodeInfo info()
inNodeService
handles such parameter.Cc: @msfroh
What other resources are available? Provide links to related issues, POCs, steps for testing, etc.
n/a
The text was updated successfully, but these errors were encountered: