-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard OpenSearch plugins to Smoke tests framework #1063
Comments
Hi @zelinh, we have already onboarded all our APIs to the api specification here which you correctly call out as a prerequisite. However, we also have written yaml tests there, see https://github.com/opensearch-project/opensearch-api-specification/blob/main/tests/default/flow_framework/workflow.yaml which seem a lot more thorough, actually testing the functionality. This effort seems duplicative (and not nearly as robust). Does this smoke test provide added value over those api spec tests? |
Hey @dbwiddis, Yes, the smoke test framework is specifically designed to validate OpenSearch distribution bundles, including TAR, RPM, and DEB packages, as part of the release process. These tests enhance release quality by ensuring each distribution type is systematically verified. To my knowledge, the tests in the api-spec repository primarily run against staging Docker images. Onboarding to this framework will provide more efficient and comprehensive sanity testing across all release artifacts, improving reliability and reducing manual effort in the release cycle. |
Sub-issue from opensearch-project/opensearch-build#5317
Background
With the smoke test framework (#5223) now established, we have successfully onboarded multiple OpenSearch plugins—including Index Management, Security, SQL, and K-NN—to the framework (PR #5255).
To maximize the effectiveness of smoke testing, we aim to onboard all OpenSearch plugins into the framework. This effort will enhance overall testing coverage, ensuring greater reliability and functionality validation for OpenSearch and its plugins.
Overview of Smoke Tests
Smoke tests verify the basic functionality of an OpenSearch distribution bundle with all plugins installed. Each plugin has its own test specification YAML file, stored in the OpenSearch Build repository and organized by major version.
These YAML files list API test cases, which the smoke test workflow executes. The results are then validated against the OpenSearch API Specification to ensure API correctness and expected behavior.
How to Onboard a Plugin
To onboard your plugin to the smoke test framework, follow the Onboarding Guide.
Steps to Onboard:
Add a YAML test file
Define API tests in the YAML file
Content-Type
header if different fromapplication/json
.Ensure the APIs are onboarded to the OpenSearch API Specification repository
Reference the test file in the test manifest
Collaboration with Plugin Owners:
We are reaching out to all OpenSearch plugin owners to facilitate onboarding. We will provide:
✅ Documentation and guidelines for onboarding.
✅ Support in setting up test cases.
✅ Assistance in troubleshooting issues.
Expected Outcome:
📢 Plugin owners: We encourage you to onboard your plugin to the smoke test framework! If you have any questions or need assistance, feel free to comment on this issue or reach out to EE team.
Let’s work together to strengthen OpenSearch’s testing and release process! 🚀
The text was updated successfully, but these errors were encountered: