Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] NPE while doing put mappings #2556

Open
navneet1v opened this issue Feb 25, 2025 · 1 comment · May be fixed by #2582
Open

[BUG] NPE while doing put mappings #2556

navneet1v opened this issue Feb 25, 2025 · 1 comment · May be fixed by #2582
Assignees
Labels
bug Something isn't working

Comments

@navneet1v
Copy link
Collaborator

What is the bug?
Getting NPE while doing PUT mappings.

How can one reproduce the bug?

  1. Create index with below mappings
curl --request PUT \
  --url http://localhost:9200/my-knn-index-1/ \
  --header 'Content-Type: application/json' \
  --data '{
	"settings": {
		"index": {
			"number_of_shards": 1,
			"number_of_replicas": 0,
			"refresh_interval": "1s",
			"knn": true
		}
	},
	"mappings": {
		"properties": {
			"my_vector2": {
				"type": "knn_vector",
				"dimension": 4,
				"method": {
					"engine": "faiss",
					"name": "hnsw"
				}
			}
		}
	}
}'
  1. Try doing put mappings like this
curl --request PUT \
  --url http://localhost:9200/my-knn-index-1/_mappings \
  --header 'Content-Type: application/json' \
  --data '{
	"properties": {
		"my_vector2": {
			"type": "knn_vector",
			"dimension": 4
		}
	}
}'

Output

{
	"error": {
		"root_cause": [
			{
				"type": "null_pointer_exception",
				"reason": "Cannot invoke \"org.opensearch.knn.index.engine.KNNMethodContext.getMethodComponentContext()\" because \"m\" is null"
			}
		],
		"type": "null_pointer_exception",
		"reason": "Cannot invoke \"org.opensearch.knn.index.engine.KNNMethodContext.getMethodComponentContext()\" because \"m\" is null"
	},
	"status": 500
}

Stacktrace:

[2025-02-25T00:07:03,874][WARN ][r.suppressed             ] [integTest-0] path: /my-knn-index-1/_mappings, params: {index=my-knn-index-1}
java.lang.NullPointerException: Cannot invoke "org.opensearch.knn.index.engine.KNNMethodContext.getMethodComponentContext()" because "m" is null
        at org.opensearch.knn.index.mapper.KNNVectorFieldMapper$Builder.lambda$new$13(KNNVectorFieldMapper.java:165) ~[?:?]
        at org.opensearch.index.mapper.ParametrizedFieldMapper$Parameter.merge(ParametrizedFieldMapper.java:347) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.ParametrizedFieldMapper$Builder.merge(ParametrizedFieldMapper.java:619) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.ParametrizedFieldMapper.merge(ParametrizedFieldMapper.java:128) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.ParametrizedFieldMapper.merge(ParametrizedFieldMapper.java:77) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.ObjectMapper.doMerge(ObjectMapper.java:821) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.RootObjectMapper.doMerge(RootObjectMapper.java:363) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.ObjectMapper.merge(ObjectMapper.java:780) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.RootObjectMapper.merge(RootObjectMapper.java:358) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.Mapping.merge(Mapping.java:130) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.index.mapper.DocumentMapper.merge(DocumentMapper.java:313) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.metadata.MetadataMappingService$PutMappingExecutor.applyRequest(MetadataMappingService.java:284) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.metadata.MetadataMappingService$PutMappingExecutor.execute(MetadataMappingService.java:245) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.service.ClusterManagerService.executeTasks(ClusterManagerService.java:889) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.service.ClusterManagerService.calculateTaskOutputs(ClusterManagerService.java:441) ~[opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.service.ClusterManagerService.runTasks(ClusterManagerService.java:301) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.service.ClusterManagerService$Batcher.run(ClusterManagerService.java:214) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.service.TaskBatcher.runIfNotProcessed(TaskBatcher.java:206) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.cluster.service.TaskBatcher$BatchedTask.run(TaskBatcher.java:264) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.common.util.concurrent.ThreadContext$ContextPreservingRunnable.run(ThreadContext.java:935) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.runAndClean(PrioritizedOpenSearchThreadPoolExecutor.java:283) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at org.opensearch.common.util.concurrent.PrioritizedOpenSearchThreadPoolExecutor$TieBreakingPrioritizedRunnable.run(PrioritizedOpenSearchThreadPoolExecutor.java:246) [opensearch-3.0.0-alpha1-SNAPSHOT.jar:3.0.0-alpha1-SNAPSHOT]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) [?:?]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) [?:?]
        at java.base/java.lang.Thread.run(Thread.java:1575) [?:?]

What is the expected behavior?
The expected behavior is we should either block these kind of update telling user that we cannot update the mapping, or it should be similar to old behavior.

What is your host/environment?
ALL

Do you have any screenshots?
NA

Do you have any additional context?
NA

@navneet1v navneet1v added bug Something isn't working untriaged and removed untriaged labels Feb 25, 2025
@oaganesh
Copy link

oaganesh commented Mar 4, 2025

Taking a look at this bug.

oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
oaganesh added a commit to oaganesh/k-NN that referenced this issue Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants