Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOEXPERIMENT check does not execute? #229

Open
davdhacs opened this issue Nov 15, 2024 · 1 comment
Open

GOEXPERIMENT check does not execute? #229

davdhacs opened this issue Nov 15, 2024 · 1 comment

Comments

@davdhacs
Copy link

Is the expResults function never executed?

// check for GOEXPERIMENT``
expResult := func() *types.ValidationError {
for _, bs := range baton.GoBuildInfo.Settings {
if bs.Key == "GOEXPERIMENT" && !strings.Contains(bs.Value, "strictfipsruntime") {
return types.NewValidationError(types.ErrGoNotGoExperiment)
}
}
return nil
}
// see https://github.com/openshift/check-payload/pull/143#issuecomment-1847671130
if tagResult != nil && expResult != nil {
return tagResult
}

@davdhacs
Copy link
Author

It appears this was noticed before also: #143 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant