Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📝 Adding Custom endpoints Documentation #3705

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

📝 Adding Custom endpoints Documentation #3705

wants to merge 5 commits into from

Conversation

dubdabasoduba
Copy link
Member

@dubdabasoduba dubdabasoduba commented Jan 27, 2025 •
edited
Loading

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #3698

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have updated the CHANGELOG.md file for any notable changes to the codebase
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide
  • I have built and run the FHIRCore app to verify my change fixes the issue and/or does not break the app
  • I have checked that this PR does NOT introduce breaking changes that require an update to Content and/or Configs? If it does add a sample here or a link to exactly what changes need to be made to the content.

Code Reviewer Checklist

  • I have verified Unit tests have been written for any new feature(s) and edge cases
  • I have verified any strings visible on UI components are in the strings.xml file
  • I have verifed the CHANGELOG.md file has any notable changes to the codebase
  • I have verified the solution has been implemented in a configurable and generic way for reuseable components
  • I have built and run the FHIRCore app to verify the change fixes the issue and/or does not break the app

@dubdabasoduba dubdabasoduba marked this pull request as draft January 27, 2025 09:17
@dubdabasoduba dubdabasoduba self-assigned this Jan 27, 2025
@dubdabasoduba dubdabasoduba added Draft DNM DO NOT MERGE labels Jan 27, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.6%. Comparing base (61f68b1) to head (7c1ab1c).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main   #3705     +/-   ##
=========================================
+ Coverage     38.5%   38.6%   +0.1%     
- Complexity    1164    1171      +7     
=========================================
  Files          286     286             
  Lines        15232   15253     +21     
  Branches      2683    2686      +3     
=========================================
+ Hits          5866    5897     +31     
+ Misses        8521    8509     -12     
- Partials       845     847      +2
Flag Coverage Δ
engine 62.9% <ø> (+0.3%) ⬆️
geowidget 16.0% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@pld pld self-requested a review January 28, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pld pld Awaiting requested review from pld

At least 1 approving review is required to merge this pull request.

Assignees

@dubdabasoduba dubdabasoduba

Labels
DNM DO NOT MERGE Draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Location Hierarchy] Document the updated approach for location hierarchy creation and search.
1 participant
@dubdabasoduba